From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Francois-Xavier Le Bail <fx.lebail@yahoo.com>, netdev@vger.kernel.org
Cc: David Stevens <dlstevens@us.ibm.com>,
Bill Fink <billfink@mindspring.com>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki Yoshifuji <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH net-next v2] ipv6: enable anycast addresses as source addresses in ICMPv6 error messages
Date: Thu, 06 Feb 2014 10:37:07 +0100 [thread overview]
Message-ID: <52F357C3.9060406@6wind.com> (raw)
In-Reply-To: <1390147236-3660-1-git-send-email-fx.lebail@yahoo.com>
Le 19/01/2014 17:00, Francois-Xavier Le Bail a écrit :
> - Uses ipv6_anycast_destination() in icmp6_send().
>
> Suggested-by: Bill Fink <billfink@mindspring.com>
> Signed-off-by: Francois-Xavier Le Bail <fx.lebail@yahoo.com>
This patch causes an Oops on my target.
Here is the step to reproduce it:
modprobe sit
ip link add sit1 type sit remote 10.16.0.121 local 10.16.0.249
ip l s sit1 up
ip -6 a a dev sit1 2001:1234::123 remote 2001:1234::121
ping6 2001:1234::121
The problem is that ipv6_anycast_destination() uses unconditionally
skb_dst(skb), which is NULL in this case.
Not sure what is the best way to fix this, any suggestions?
Regards,
Nicolas
next prev parent reply other threads:[~2014-02-06 9:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-19 16:00 [PATCH net-next v2] ipv6: enable anycast addresses as source addresses in ICMPv6 error messages Francois-Xavier Le Bail
2014-01-20 15:54 ` Hannes Frederic Sowa
2014-01-22 0:53 ` David Miller
2014-02-06 9:37 ` Nicolas Dichtel [this message]
2014-02-06 12:38 ` François-Xavier Le Bail
2014-02-06 14:01 ` Nicolas Dichtel
2014-02-06 14:30 ` François-Xavier Le Bail
2014-02-06 16:29 ` Nicolas Dichtel
2014-02-07 9:33 ` Nicolas Dichtel
2014-02-07 10:04 ` François-Xavier Le Bail
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F357C3.9060406@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=billfink@mindspring.com \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=fx.lebail@yahoo.com \
--cc=hannes@stressinduktion.org \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.