From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH] xen/arm: Correctly implement domain_page_map_to_mfn Date: Thu, 6 Feb 2014 12:03:31 +0000 Message-ID: <52F37A13.7020909@eu.citrix.com> References: <1391609794-505-1-git-send-email-julien.grall@linaro.org> <52F24FF3.5050107@eu.citrix.com> <1391688129.23098.103.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WBNgR-0004uf-Et for xen-devel@lists.xenproject.org; Thu, 06 Feb 2014 12:03:55 +0000 In-Reply-To: <1391688129.23098.103.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: patches@linaro.org, Julien Grall , tim@xen.org, George Dunlap , stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 02/06/2014 12:02 PM, Ian Campbell wrote: > On Wed, 2014-02-05 at 14:51 +0000, George Dunlap wrote: >> On 02/05/2014 02:16 PM, Julien Grall wrote: >>> The function domain_page_map_to_mfn can be used to translate a virtual >>> address mapped by both map_domain_page and map_domain_page_global. >>> The former is using vmap to map the mfn, therefore domain_page_map_to_mfn >>> will always fail because the address is not in DOMHEAP range. >>> >>> Check if the address is in vmap range and use __pa to translate it. >>> >>> This patch fix guest shutdown when the event fifo is used. >>> >>> Signed-off-by: Julien Grall >> I assume this brings the arm paths into line with the x86 functionality? > Yes, functionality which is now expected by common code as well (FIFO > evthcn stuff). In that case: Release-acked-by: George Dunlap