From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen: arm: arm64: Adding VFP save/restore support. Date: Thu, 06 Feb 2014 13:08:08 +0000 Message-ID: <52F38938.2090500@linaro.org> References: <1391671722-16127-1-git-send-email-pranavkumar@linaro.org> <52F38394.50405@linaro.org> <1391691427.23098.118.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1391691427.23098.118.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Anup Patel , patches@linaro.org, patches@apm.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, Pranavkumar Sawargaonkar List-Id: xen-devel@lists.xenproject.org On 06/02/14 12:57, Ian Campbell wrote: > On Thu, 2014-02-06 at 12:44 +0000, Julien Grall wrote: >>> + :: "r" ((char *)(&v->arch.vfp.fpregs)): "memory"); >> >> I remember we had a discussion when I have implemented vfp context >> switch for arm32 for the memory constraints >> (http://lists.xen.org/archives/html/xen-devel/2013-06/msg00110.html). >> >> I think you should use "=Q" also here to avoid cloberring the whole memory. > > Yes, I forgot to say: I think getting something in now is the priority, > which is why I committed it, but this should be tightened up, probably > for 4.5 unless the difference is benchmarkable. The fix is very simple (a matter of 2 lines changes). I would prefer to delay this patch for a couple of days and having a correct implementation from the beginning, so we will not forgot to change the code for Xen 4.5. Moreover Pranav usually answer quickly :). -- Julien Grall