From: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
To: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
Florian Meier <florian.meier-oZ8rN/sblLk@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: pcm512x: Add PCM512x driver
Date: Thu, 06 Feb 2014 14:16:23 +0100 [thread overview]
Message-ID: <52F38B27.1040502@metafoo.de> (raw)
In-Reply-To: <s5hob2kv0z3.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
On 02/06/2014 02:12 PM, Takashi Iwai wrote:
> At Thu, 6 Feb 2014 13:07:35 +0000,
> Mark Brown wrote:
[...]
>> Hrm, it is but this points out an error in the control helpers which has
>> been there since forever - they call that parameter max but it's not a
>> maximum, it's the number of elements in the enumeration. I bet we have
>> a bunch of other enumerations which miss the last element as a result.
>
> Yeah, the argument name is really confusing. I had to double-check
> the code when I reviewed your patch, too :)
>
> Also it'd be better to have a practice to use either ARRAY_SIZE() or a
> constant there, too.
There is also SOC_ENUM_SINGLE_DECL(...) which takes care of the common case
where you want as many items as your array contains.
- Lars
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-02-06 13:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 12:26 [PATCH] ASoC: pcm512x: Add PCM512x driver Mark Brown
[not found] ` <1391689575-4039-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-02-06 12:51 ` [alsa-devel] " Takashi Iwai
[not found] ` <s5hr47gv1yi.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2014-02-06 13:07 ` Mark Brown
[not found] ` <20140206130735.GP32298-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-02-06 13:12 ` Takashi Iwai
[not found] ` <s5hob2kv0z3.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2014-02-06 13:16 ` Lars-Peter Clausen [this message]
[not found] ` <52F38B27.1040502-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-02-06 13:19 ` Takashi Iwai
2014-02-06 13:50 ` Mark Brown
2014-02-18 11:22 ` Takashi Iwai
2014-02-23 3:07 ` Mark Brown
2014-02-23 8:29 ` Takashi Iwai
2014-02-24 1:29 ` Mark Brown
2014-02-06 13:24 ` [alsa-devel] " Lars-Peter Clausen
[not found] ` <52F38CF7.7060306-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-02-06 14:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F38B27.1040502@metafoo.de \
--to=lars-qo5elluwu/uelga04laivw@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=florian.meier-oZ8rN/sblLk@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
--cc=tiwai-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.