From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.candelatech.com ([208.74.158.172] helo=ns3.lanforge.com) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WBQlR-0002J3-J6 for ath10k@lists.infradead.org; Thu, 06 Feb 2014 15:21:18 +0000 Message-ID: <52F3A856.6010002@candelatech.com> Date: Thu, 06 Feb 2014 07:20:54 -0800 From: Ben Greear MIME-Version: 1.0 Subject: Re: [PATCH 4/4] ath10k: Better tx/rx debugging. References: <1390435562-15473-1-git-send-email-greearb@candelatech.com> <1390435562-15473-4-git-send-email-greearb@candelatech.com> <87lhxqoghd.fsf@kamboji.qca.qualcomm.com> <874n4enkbs.fsf@kamboji.qca.qualcomm.com> <52F26BF1.7030105@candelatech.com> <874n4ckbns.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <874n4ckbns.fsf@kamboji.qca.qualcomm.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: Janusz Dziedzic , Marek Puzyniak , ath10k@lists.infradead.org On 02/05/2014 10:17 PM, Kalle Valo wrote: > Ben Greear writes: > >> On 02/05/2014 01:10 AM, Marek Puzyniak wrote: >> >>>>> So probably it would be better to have choice to enable this log print >>>>> when someone need this information otherwise by default it should be >>>>> disabled. >>>> >>>> Maybe a debug message is better? >>> Yes, for example with flag ATH10K_DBG_HTT. >> >> That one is pretty spammy already..maybe I can create a new flag >> ATH10K_DBG_RX or something like that that is specifically for RX logic >> debugging? > > Yeah, that would be good. And then we can later add _TX for transmit > side. Patches I sent did not have this new bit...but I can add that next time I work on this code. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k