From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [libvirt] [PATCH 0/4] libxl: fixes related to concurrency improvements Date: Thu, 06 Feb 2014 10:36:26 -0700 Message-ID: <52F3C81A.5080008@suse.com> References: <1391621986-7341-1-git-send-email-jfehlig@suse.com> <52F385BE.5020509@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52F385BE.5020509@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Michal Privoznik Cc: libvir-list@redhat.com, xen-devel@lists.xen.org, bjzhang@suse.com List-Id: xen-devel@lists.xenproject.org Michal Privoznik wrote: > On 05.02.2014 18:39, Jim Fehlig wrote: >> While reviving old patches to add job support to the libxl driver, >> testing revealed some problems that were difficult to encounter >> in the current, more serialized processing approach used in the >> driver. >> >> The first patch is a bug fix, plugging leaks of libxlDomainObjPrivate >> objects. The second patch removes the list of libxl timer registrations >> maintained in the driver - a hack I was never fond of. The third patch >> moves domain shutdown handling to a thread, instead of doing all the >> shutdown work in the event handler. The fourth patch fixes an issue wrt >> child process handling discussed in this thread >> >> http://lists.xen.org/archives/html/xen-devel/2014-01/msg01553.html >> >> Ian Jackson's latest patches on the libxl side are here >> >> http://lists.xen.org/archives/html/xen-devel/2014-02/msg00124.html >> >> >> Jim Fehlig (4): >> libxl: fix leaking libxlDomainObjPrivate >> libxl: remove list of timer registrations from libxlDomainObjPrivate >> libxl: handle domain shutdown events in a thread >> libxl: improve subprocess handling >> >> src/libxl/libxl_conf.h | 5 +- >> src/libxl/libxl_domain.c | 102 ++++++++--------------------------- >> src/libxl/libxl_domain.h | 8 +-- >> src/libxl/libxl_driver.c | 135 >> +++++++++++++++++++++++++++++++---------------- >> 4 files changed, 115 insertions(+), 135 deletions(-) >> > > ACK series but see my comment on 3/4 where I'm asking for a pair of > fixes prior pushing. Thanks for pointing those out, especially creating the joinable thread that was never joined :). Fixed. I also added a note to the commit message of 4/4 stating that the fixes on the libxl side will be included in Xen 4.4.0 http://lists.xen.org/archives/html/xen-devel/2014-02/msg00463.html Pushed series. Thanks! Regards, Jim