All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: andrew.cooper3@citrix.com, keir@xen.org,
	suravee.suthikulpanit@amd.com, xen-devel@lists.xen.org
Subject: Re: [PATCH V2] x86/AMD: Apply workaround for AMD F16h Erratum792
Date: Thu, 6 Feb 2014 13:11:34 -0600	[thread overview]
Message-ID: <52F3DE66.7010800@amd.com> (raw)
In-Reply-To: <52F370EC0200007800119B43@nat28.tlf.novell.com>

On 2/6/2014 4:24 AM, Jan Beulich wrote:
>>>> On 05.02.14 at 22:43, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> wrote:
>> +
>>   		rdmsrl(MSR_AMD64_LS_CFG, value);
>>   		if (!(value & (1 << 15))) {
>>   			static bool_t warned;
> The patch context even shows what is missing: A diagnostic
> message making it possible to know that the workaround was
> applied. Of course you don't need two separate messages for
> the two parts of the workaround, but indicating in the message
> which of them was applied would seem desirable.
>
> Furthermore, I don't see why you would need a new local
> variable here at all - there are two suitable variables available
> throughout the entire function (l and h).
>
>
Okay, corrected the patch as per your comments.
Sending it out as V3.

-Aravind

      reply	other threads:[~2014-02-06 19:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05 21:43 [PATCH V2] x86/AMD: Apply workaround for AMD F16h Erratum792 Aravind Gopalakrishnan
2014-02-05 21:27 ` Andrew Cooper
2014-02-06 10:24 ` Jan Beulich
2014-02-06 19:11   ` Aravind Gopalakrishnan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F3DE66.7010800@amd.com \
    --to=aravind.gopalakrishnan@amd.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=keir@xen.org \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.