From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ding Tianhong Subject: Re: [PATCH RESEND net-next] bonding: don't permit slaves to change their mtu independently Date: Fri, 7 Feb 2014 11:56:46 +0800 Message-ID: <52F4597E.8010401@huawei.com> References: <52E343AD.3080402@huawei.com> <20140206.194107.170476650427156102.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: , , , To: David Miller Return-path: Received: from szxga02-in.huawei.com ([119.145.14.65]:7330 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751064AbaBGD5X (ORCPT ); Thu, 6 Feb 2014 22:57:23 -0500 In-Reply-To: <20140206.194107.170476650427156102.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On 2014/2/7 11:41, David Miller wrote: > From: Ding Tianhong > Date: Sat, 25 Jan 2014 12:55:09 +0800 > >> I have come to a conclusion by testing all modes for mtu changing: >> >> 1). If the slaves support changing mtu and no need to restart the device, >> just like virtual nic, the master will not lost any packages for all >> mode. >> >> 2). If the slaves support changing mtu and need to restart the device, >> just like Intel 82599, the AB, 802.3, ALB and TLB mode may lost >> packages, but other modes could work well. >> >> The reason is that when the slave's mtu has been changed, the slave's hw will >> restart, if the slave is current active slave, the master may set the >> slave to backup state and reselect a new slave, after the reselect processing, >> the master could work again, but if in load-balance mode, the master could >> select another active slave to send and recv packages. >> >> So the best way to fix the problem is don't permit slave to change their >> mtu independently. >> >> Cc: Jay Vosburgh >> Cc: Veaceslav Falico >> Cc: Andy Gospodarek >> Signed-off-by: Ding Tianhong > > Without any review, I'm not applying this patch, sorry. > > Ok, and I found some new issue for this patch, maybe need more discussion. Regards Ding