All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Peter Maydell <peter.maydell@linaro.net>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Alex Bligh <alex@alex.org.uk>,
	Miroslav Rezanina <mrezanin@redhat.com>,
	Lluis Vilanova <vilanova@ac.upc.edu>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v18 00/10] Shared library module support
Date: Fri, 07 Feb 2014 12:14:00 +0400	[thread overview]
Message-ID: <52F495C8.8030800@msgid.tls.msk.ru> (raw)
In-Reply-To: <52F4879E.7040300@redhat.com>

07.02.2014 11:13, Paolo Bonzini wrote:
> Il 07/02/2014 01:06, Peter Maydell ha scritto:
>> Why do we need OS specific code to do this when the code
>> in vl.c for getting the executable path to use as a base for
>> finding bios blobs works fine without OS specific code?
> 
> That's because right now module_call_init is not receiving an argv[0] to pass to qemu_exec_dir (os_find_datadir has an argument for that).  It can be fixed (in the whole call chain, including e.g. bdrv_init/bdrv_init_with_whitelist).

We can add a global variable (either executable_dir or whole -L path),
init it in vl.c as we do now, and use it in other places in a uniform
way.

BTW, It'd be really good to have a separate, arch-specific directory for
the plugins, like /usr/lib/x86_64-linux-gnu/qemu/, so it will be
multiarch-able.  But it is not really a show-stopper.

Thanks,

/mjt

  reply	other threads:[~2014-02-07  8:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-31 14:49 [Qemu-devel] [PATCH v18 00/10] Shared library module support Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 01/10] util: Split out qemu_exec_dir from os_find_datadir Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 02/10] rules.mak: fix $(obj) to a real relative path Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 03/10] rules.mak: allow per object cflags and libs Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 04/10] block: use per-object " Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 05/10] darwin: do not use -mdynamic-no-pic Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 06/10] rules.mak: introduce DSO rules Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 07/10] module: implement module loading Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 08/10] Makefile: install modules with "make install" Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 09/10] Makefile: introduce common-obj-m and block-obj-m for DSO Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 10/10] block: convert block drivers linked with libs to modules Paolo Bonzini
2014-02-05 18:19 ` [Qemu-devel] [PATCH v18 00/10] Shared library module support Peter Maydell
2014-02-06 23:38   ` Paolo Bonzini
2014-02-07  0:06     ` Peter Maydell
2014-02-07  7:13       ` Paolo Bonzini
2014-02-07  8:14         ` Michael Tokarev [this message]
2014-02-07  8:38           ` Paolo Bonzini
2014-02-07  8:40           ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F495C8.8030800@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=alex@alex.org.uk \
    --cc=kwolf@redhat.com \
    --cc=mrezanin@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    --cc=vilanova@ac.upc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.