Re: [PATCH 1/2] libsocketcan: Initialize stack variables properly

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1398 bytes --]

On 02/07/2014 10:21 AM, Alexander Shiyan wrote:
> Stack variables may have unpredictable data if it not initialized.
> This patch adds the necessary cleanup stack variables.
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  src/libsocketcan.c | 40 ++++++++++++++++++++++------------------
>  1 file changed, 22 insertions(+), 18 deletions(-)
> 
> diff --git a/src/libsocketcan.c b/src/libsocketcan.c
> index 02714ae..4e7842f 100644
> --- a/src/libsocketcan.c
> +++ b/src/libsocketcan.c
> @@ -705,6 +705,7 @@ int can_do_stop(const char *name)
>   */
>  int can_do_restart(const char *name)
>  {
> +	struct req_info req;
>  	int err = -1;
>  	int state;
>  	__u32 restart_ms;
> @@ -731,11 +732,10 @@ int can_do_restart(const char *name)
>  		goto err_out;
>  	}
>  
> -	struct req_info req_info = {
> -		.restart = 1,
> -	};
> +	memset(&req, 0, sizeof(req));
> +	req.restart = 1;

This is equivalent, all other members of req_info are set to 0x0,
guaranteed by C standard. It was added with C99 and support by gcc for a
long time.

If think we can drop the patch.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]