All of lore.kernel.org
 help / color / mirror / Atom feed
From: b.brezillon@overkiz.com (Boris BREZILLON)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: at91: remove redundant assignment
Date: Fri, 07 Feb 2014 11:39:49 +0100	[thread overview]
Message-ID: <52F4B7F5.5020704@overkiz.com> (raw)
In-Reply-To: <52F4AF3F.7040809@atmel.com>

Hi Nicolas, Colin,

On 07/02/2014 11:02, Nicolas Ferre wrote:
> On 06/02/2014 19:53, Colin King :
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> remove the redundant shift = shift assignment, it is extraneous.
Thanks for reporting and fixing this.

>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> Thanks.
>
> Boris, can you integrate this patch to the "fixes" series that will be
> sent to Mike during the 3.14 development cycle?

The round_rate function has been replaced by determine_rate and thus the 
bug is not present anymore.

See JJ's series: 
http://us.generation-nt.com/patch-v2-0-4-clk-at91-better-support-pcks-help-213900572.html

Best Regards,

Boris

> Bye,
>
>> ---
>>   drivers/clk/at91/clk-programmable.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/at91/clk-programmable.c b/drivers/clk/at91/clk-programmable.c
>> index fd792b2..ff86efe 100644
>> --- a/drivers/clk/at91/clk-programmable.c
>> +++ b/drivers/clk/at91/clk-programmable.c
>> @@ -109,7 +109,7 @@ static long clk_programmable_round_rate(struct clk_hw *hw, unsigned long rate,
>>   	unsigned long best_diff;
>>   	unsigned long new_diff;
>>   	unsigned long cur_rate;
>> -	int shift = shift;
>> +	int shift;
>>   
>>   	if (rate > *parent_rate)
>>   		return *parent_rate;
>>
>

      reply	other threads:[~2014-02-07 10:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-06 18:53 [PATCH] clk: at91: remove redundant assignment Colin King
2014-02-07 10:02 ` Nicolas Ferre
2014-02-07 10:39   ` Boris BREZILLON [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F4B7F5.5020704@overkiz.com \
    --to=b.brezillon@overkiz.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.