Re: [PATCH 3/6] bus: mvebu: add mbus driver

[Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>]

On 02/07/14 07:58, Sascha Hauer wrote:
> [...]
>
>> +
>> +static const struct mvebu_mbus_soc_data orion5x_2win_mbus_data = {
>> +	.num_wins            = 8,
>> +	.num_remappable_wins = 2,
>> +	.win_cfg_offset      = orion5x_mbus_win_offset,
>> +	.setup_cpu_target    = mvebu_mbus_default_setup_cpu_target,
>> +};
>> +
>> +static const struct mvebu_mbus_soc_data mv78xx0_mbus_data = {
>> +	.num_wins            = 14,
>> +	.num_remappable_wins = 8,
>> +	.win_cfg_offset      = mv78xx0_mbus_win_offset,
>> +	.setup_cpu_target    = mvebu_mbus_default_setup_cpu_target,
>> +};
>
> Don't you end up with unused variable warnings here if not all SoCs are
> enabled? Maybe add some __maybe_unused here.

Hmm, neither V=1 nor W=1 makes gcc shout warnings here. Apparently, this
may be a "bug" in gcc, not producing warnings for unused consts... but
they are not variables strictly speaking.

Removing the const above makes gcc shout, I'll add the __maybe_unused
anyway.

>> +static struct of_device_id mvebu_mbus_dt_ids[] = {

And maybe constify this too.

Sebastian

>> +#if defined(CONFIG_ARCH_ARMADA_370) || defined(CONFIG_ARCH_ARMADA_XP)
>> +	{ .compatible = "marvell,armada370-mbus",
>> +	  .data = (u32)&armada_370_xp_mbus_data, },
>> +	{ .compatible = "marvell,armadaxp-mbus",
>> +	  .data = (u32)&armada_370_xp_mbus_data, },
>> +#endif
>> +#if defined(CONFIG_ARCH_DOVE)
>> +	{ .compatible = "marvell,dove-mbus",
>> +	  .data = (u32)&dove_mbus_data, },
>> +#endif


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox