From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH v3 5/7] ARM: dts: Exynos: add cpu nodes, opp and cpu clock configuration data Date: Fri, 07 Feb 2014 16:20:27 +0000 Message-ID: <52F507CB.6090300@arm.com> References: <1391788548-13056-1-git-send-email-thomas.ab@samsung.com> <1391788548-13056-6-git-send-email-thomas.ab@samsung.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1391788548-13056-6-git-send-email-thomas.ab@samsung.com> Sender: cpufreq-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Thomas Abraham , "cpufreq@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Cc: Sudeep.Holla@arm.com, "l.majewski@samsung.com" , "kgene.kim@samsung.com" , "mturquette@linaro.org" , "heiko@sntech.de" , "viresh.kumar@linaro.org" , "t.figa@samsung.com" , "linux-samsung-soc@vger.kernel.org" , "thomas.ab@samsung.com" , "shawn.guo@linaro.org" On 07/02/14 15:55, Thomas Abraham wrote: > From: Thomas Abraham > > For all Exynos based platforms, add CPU nodes, operating points and cpu > clock data for migrating from Exynos specific cpufreq driver to using > generic cpufreq-cpu0 driver. > > Signed-off-by: Thomas Abraham [...] > diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi > index 5c412aa..c613fc2 100644 > --- a/arch/arm/boot/dts/exynos4x12.dtsi > +++ b/arch/arm/boot/dts/exynos4x12.dtsi > @@ -31,6 +31,42 @@ > mshc0 = &mshc_0; > }; > > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + cpu@0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a9"; > + reg = <0>; > + clocks = <&clock 12>; > + clock-names = "cpu"; > + > + operating-points = < > + 1500000 1350000 > + 1400000 1287500 > + 1300000 1250000 > + 1200000 1187500 > + 1100000 1137500 > + 1000000 1087500 > + 900000 1037500 > + 800000 1000000 > + 700000 987500 > + 600000 975000 > + 500000 950000 > + 400000 925000 > + 300000 900000 > + 200000 900000 > + >; > + clock-latency = <200000>; > + boost-frequency = <1500000 1350000>; This is confusing, 1350000 is not in the OPP frequency list or this is still following old binding with voltage. Either case this needs to be fixed. Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep.Holla@arm.com (Sudeep Holla) Date: Fri, 07 Feb 2014 16:20:27 +0000 Subject: [PATCH v3 5/7] ARM: dts: Exynos: add cpu nodes, opp and cpu clock configuration data In-Reply-To: <1391788548-13056-6-git-send-email-thomas.ab@samsung.com> References: <1391788548-13056-1-git-send-email-thomas.ab@samsung.com> <1391788548-13056-6-git-send-email-thomas.ab@samsung.com> Message-ID: <52F507CB.6090300@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/02/14 15:55, Thomas Abraham wrote: > From: Thomas Abraham > > For all Exynos based platforms, add CPU nodes, operating points and cpu > clock data for migrating from Exynos specific cpufreq driver to using > generic cpufreq-cpu0 driver. > > Signed-off-by: Thomas Abraham [...] > diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi > index 5c412aa..c613fc2 100644 > --- a/arch/arm/boot/dts/exynos4x12.dtsi > +++ b/arch/arm/boot/dts/exynos4x12.dtsi > @@ -31,6 +31,42 @@ > mshc0 = &mshc_0; > }; > > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + cpu at 0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a9"; > + reg = <0>; > + clocks = <&clock 12>; > + clock-names = "cpu"; > + > + operating-points = < > + 1500000 1350000 > + 1400000 1287500 > + 1300000 1250000 > + 1200000 1187500 > + 1100000 1137500 > + 1000000 1087500 > + 900000 1037500 > + 800000 1000000 > + 700000 987500 > + 600000 975000 > + 500000 950000 > + 400000 925000 > + 300000 900000 > + 200000 900000 > + >; > + clock-latency = <200000>; > + boost-frequency = <1500000 1350000>; This is confusing, 1350000 is not in the OPP frequency list or this is still following old binding with voltage. Either case this needs to be fixed. Regards, Sudeep