From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52082)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WBppX-0007h2-6Y
	for qemu-devel@nongnu.org; Fri, 07 Feb 2014 13:07:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WBppP-0003WO-S0
	for qemu-devel@nongnu.org; Fri, 07 Feb 2014 13:07:11 -0500
Received: from cantor2.suse.de ([195.135.220.15]:34707 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WBppP-0003WE-Lm
	for qemu-devel@nongnu.org; Fri, 07 Feb 2014 13:07:03 -0500
Message-ID: <52F520C2.3030908@suse.de>
Date: Fri, 07 Feb 2014 19:06:58 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1391619677-32387-1-git-send-email-afaerber@suse.de>
	<1391619677-32387-2-git-send-email-afaerber@suse.de>
	<20140207154857.GC25412@stefanha-thinkpad.redhat.com>
In-Reply-To: <20140207154857.GC25412@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-next 1/5] tests: Add e1000 qtest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org

Am 07.02.2014 16:48, schrieb Stefan Hajnoczi:
> On Wed, Feb 05, 2014 at 06:01:13PM +0100, Andreas F=E4rber wrote:
>> +#include "libqtest.h"
>> +
>> +#include <glib.h>
>> +#include <string.h>
>> +#include "qemu/osdep.h"
>=20
> Please put <system.h> includes before "user.h" includes.  That way we
> can be sure our macros don't mess up system headers.

You are right in this case, but to my defense I copied this from another
file. ;) You'll find the "libqtest.h"-first pattern in:

endianness-test.c
fw_cfg-test.c
i440fx-test.c
m48t59-test.c
qom-test.c
rtc-test.c
tmp105-test.c

To make it clearer which example to copy from, feel free to submit a
patch cleaning those up.

NB in general it can be a valid technique to place a single "user.h" in
user.c before the usual <system> and "user" headers to assure that it
does not depend on external includes, but clearly that's not the case her=
e.

>> +
>> +static void nop(void)
>> +{
>> +}
>=20
> I suggest a comment here to explain the point of this test:
> /* The point of this test case is just to instantiate the device */

Thanks, will add a TODO.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg