All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>, unlisted-recipients:;
Cc: KVM list <kvm@vger.kernel.org>, chickenmarkus@freenet.de
Subject: Re: Fwd: Discard is not working
Date: Fri, 07 Feb 2014 22:07:44 +0100	[thread overview]
Message-ID: <52F54B20.6030305@redhat.com> (raw)
In-Reply-To: <52F50BA3.10309@msgid.tls.msk.ru>

Il 07/02/2014 17:36, Michael Tokarev ha scritto:
> However, when I export the same test.raw file using virtio, like this:
>
>  -drive file=test.raw,if=virtio,discard=unmap
>
> it doesn't work: guest does not see the virtio drive as discardable.
>
>> > Did I understand something wrong? Is the command wrong? Are any
>> > requirements not met?
> So I've no idea what's going on here... ;)

Thanks Michael for the experiments!  I missed this email.

virtio-blk does not support discard, so this is expected.

Regarding lsblk -D, DISC-ZERO is never true in VMs (not yet at least!), 
but the important one is DISC-GRAN.

Paolo

      parent reply	other threads:[~2014-02-07 21:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05 22:53 Discard is not working chickenmarkus
2014-02-07 15:51 ` Fwd: " chickenmarkus
     [not found] ` <52F422C2.9020509@redhat.com>
2014-02-07 16:36   ` Michael Tokarev
2014-02-07 20:19     ` chickenmarkus
2014-02-07 21:07     ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F54B20.6030305@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=chickenmarkus@freenet.de \
    --cc=kvm@vger.kernel.org \
    --cc=mjt@tls.msk.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.