From: Laszlo Ersek <lersek@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] blkdebug: Don't leak bs->file on failure
Date: Sat, 08 Feb 2014 10:57:24 +0100 [thread overview]
Message-ID: <52F5FF84.5010106@redhat.com> (raw)
In-Reply-To: <20140208095537.GD2954@dhcp-200-207.str.redhat.com>
On 02/08/14 10:55, Kevin Wolf wrote:
> Am 08.02.2014 um 10:46 hat Laszlo Ersek geschrieben:
>> How about the attached patch instead? Releasing stuff in specific error
>> handler blocks quickly becomes intractable if there are many resources
>> to allocate in succession, but in this case I think we can easily get
>> away with it.
>
> I'd prefer to avoid this because it's too easy to miss it when you add
> new code to the function.
Oh, right. If you actually care about the future, this is a good point :)
Thanks!
Laszlo
prev parent reply other threads:[~2014-02-08 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 8:54 [Qemu-devel] [PATCH] blkdebug: Don't leak bs->file on failure Kevin Wolf
2014-02-08 9:46 ` Laszlo Ersek
2014-02-08 9:55 ` Kevin Wolf
2014-02-08 9:57 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F5FF84.5010106@redhat.com \
--to=lersek@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.