From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Michael L. Semon" <mlsemon35@gmail.com>,
JFS Discussion <jfs-discussion@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] jfs: fix generic posix ACL regression
Date: Sat, 08 Feb 2014 10:37:25 -0600 [thread overview]
Message-ID: <52F65D45.5070206@oracle.com> (raw)
In-Reply-To: <20140208070818.GA8758@lst.de>
On 02/08/2014 01:08 AM, Christoph Hellwig wrote:
> On Fri, Feb 07, 2014 at 02:59:20PM -0600, Dave Kleikamp wrote:
>> -#ifdef JFS_POSIX_ACL
>> +#ifdef CONFIG_JFS_POSIX_ACL
>
> Ooops, sorry.
>
> I don't understand the can_set_xattr move - while the check obviously
> aren't needed when using the generic xattr code I don't see how they
> cause harm either.
Your patchset removed the XATTR_SYSTEM_PREFIX bits from can_set_xattr,
so it will not recognize the ACL as valid and return -EOPNOTSUPP.
next prev parent reply other threads:[~2014-02-08 16:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 20:59 [PATCH] jfs: fix generic posix ACL regression Dave Kleikamp
2014-02-08 6:01 ` Michael L. Semon
2014-02-08 7:08 ` Christoph Hellwig
2014-02-08 16:37 ` Dave Kleikamp [this message]
2014-02-08 16:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F65D45.5070206@oracle.com \
--to=dave.kleikamp@oracle.com \
--cc=hch@lst.de \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlsemon35@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.