From: "Andreas Färber" <afaerber@suse.de>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 11/11] i2c: Drop FROM_I2C_SLAVE() macro
Date: Sun, 09 Feb 2014 13:49:17 +0100 [thread overview]
Message-ID: <52F7794D.7040302@suse.de> (raw)
In-Reply-To: <CAEgOgz7m_m_kYKF_zqeiRyfPj-DjcxNAz5xU9vN9KhgLDA87Nw@mail.gmail.com>
Am 09.02.2014 02:53, schrieb Peter Crosthwaite:
> On Sat, Feb 1, 2014 at 12:34 AM, Andreas Färber <afaerber@suse.de> wrote:
>> Use type-specific QOM cast macros instead.
>>
>
> Should be past tense - "We now use type-specific ...". The imperative
> form of "use" suggests you are making the change in this patch but you
> have already done it.
It was meant as a guidance for resolving conflicts due to lack of that
macro, not as a description of past patches. I've adopted your wording.
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-02-09 12:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 14:34 [Qemu-devel] [PATCH 00/11] I2C QOM'ification, part 1 Andreas Färber
2014-01-31 14:34 ` [Qemu-devel] [PATCH 01/11] i2c: Rename i2c_bus to I2CBus Andreas Färber
2014-02-09 1:24 ` Peter Crosthwaite
2014-01-31 14:34 ` [Qemu-devel] [PATCH 02/11] pxa2xx: QOM'ify I2C slave Andreas Färber
2014-02-09 1:35 ` Peter Crosthwaite
2014-02-09 12:24 ` Andreas Färber
2014-02-09 12:36 ` Peter Maydell
2014-02-09 12:56 ` Andreas Färber
2014-01-31 14:34 ` [Qemu-devel] [PATCH 03/11] tosa: QOM'ify DAC Andreas Färber
2014-02-09 1:37 ` Peter Crosthwaite
2014-01-31 14:34 ` [Qemu-devel] [PATCH 04/11] z2: QOM'ify AER915 Andreas Färber
2014-02-09 1:38 ` Peter Crosthwaite
2014-02-09 13:04 ` Andreas Färber
2014-01-31 14:34 ` [Qemu-devel] [PATCH 05/11] wm8750: QOM'ify Andreas Färber
2014-02-09 1:41 ` Peter Crosthwaite
2014-02-09 13:10 ` Andreas Färber
2014-01-31 14:34 ` [Qemu-devel] [PATCH 06/11] ssd0303: QOM'ify Andreas Färber
2014-02-09 1:42 ` Peter Crosthwaite
2014-01-31 14:34 ` [Qemu-devel] [PATCH 07/11] max7310: QOM'ify Andreas Färber
2014-02-09 1:43 ` Peter Crosthwaite
2014-01-31 14:34 ` [Qemu-devel] [PATCH 08/11] lm832x: QOM'ify Andreas Färber
2014-02-09 1:45 ` Peter Crosthwaite
2014-01-31 14:34 ` [Qemu-devel] [PATCH 09/11] ds1338: QOM'ify Andreas Färber
2014-02-09 1:45 ` Peter Crosthwaite
2014-01-31 14:34 ` [Qemu-devel] [PATCH 10/11] twl92230: QOM'ify Andreas Färber
2014-02-09 1:50 ` Peter Crosthwaite
2014-01-31 14:34 ` [Qemu-devel] [PATCH 11/11] i2c: Drop FROM_I2C_SLAVE() macro Andreas Färber
2014-02-09 1:53 ` Peter Crosthwaite
2014-02-09 12:49 ` Andreas Färber [this message]
2014-02-08 17:22 ` [Qemu-devel] [PATCH 00/11] I2C QOM'ification, part 1 Andreas Färber
2014-02-09 1:29 ` Peter Crosthwaite
2014-02-09 1:59 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F7794D.7040302@suse.de \
--to=afaerber@suse.de \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.