From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCU9x-0005he-Q9 for qemu-devel@nongnu.org; Sun, 09 Feb 2014 08:11:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCU9r-0008HU-RZ for qemu-devel@nongnu.org; Sun, 09 Feb 2014 08:10:57 -0500 Received: from cantor2.suse.de ([195.135.220.15]:53149 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCU9r-0008HQ-LA for qemu-devel@nongnu.org; Sun, 09 Feb 2014 08:10:51 -0500 Message-ID: <52F77E56.6060701@suse.de> Date: Sun, 09 Feb 2014 14:10:46 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1391178886-17277-1-git-send-email-afaerber@suse.de> <1391178886-17277-6-git-send-email-afaerber@suse.de> In-Reply-To: <1391178886-17277-6-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 05/11] wm8750: QOM'ify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Vassili Karpov (malc)" , Gerd Hoffmann Am 31.01.2014 15:34, schrieb Andreas F=C3=A4rber: > Replace usages of FROM_I2C_SLAVE() with QOM cast macro. > Rename parent field. >=20 > Signed-off-by: Andreas F=C3=A4rber > --- > hw/audio/wm8750.c | 33 ++++++++++++++++++++------------- > 1 file changed, 20 insertions(+), 13 deletions(-) Follow-up TODO: Move wm8750_*() prototypes out of include/hw/i2c/i2c.h a) as header cleanup, b) to place TYPE_WM8750 in an include/hw/audio/wm8750.h for reuse in z2.c, spitz.c, musicpal.c. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg