From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53699)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WCW1R-0000MU-05
	for qemu-devel@nongnu.org; Sun, 09 Feb 2014 10:10:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WCW1J-0000Me-M6
	for qemu-devel@nongnu.org; Sun, 09 Feb 2014 10:10:16 -0500
Received: from cantor2.suse.de ([195.135.220.15]:54656 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WCW1J-0000MZ-GA
	for qemu-devel@nongnu.org; Sun, 09 Feb 2014 10:10:09 -0500
Message-ID: <52F79A4B.5060404@suse.de>
Date: Sun, 09 Feb 2014 16:10:03 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1391877522-17254-1-git-send-email-mark.cave-ayland@ilande.co.uk>
	<1391877522-17254-2-git-send-email-mark.cave-ayland@ilande.co.uk>
In-Reply-To: <1391877522-17254-2-git-send-email-mark.cave-ayland@ilande.co.uk>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCHv2 1/2] sun4m: Add Sun CG3 framebuffer and
 corresponding OpenBIOS FCode ROM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Blue Swirl <blauwirbel@gmail.com>, Bob Breuer <breuerr@mc.net>, Anthony Liguori <aliguori@amazon.com>, Paolo Bonzini <pbonzini@redhat.com>, Artyom Tarasenko <atar4qemu@gmail.com>

Hi,

Am 08.02.2014 17:38, schrieb Mark Cave-Ayland:
> +static Property cg3_properties[] =3D {
> +    DEFINE_PROP_HEX32("vram_size",     CG3State, vram_size, -1),

Paolo is about to drop hex32 ...

> +    DEFINE_PROP_UINT16("width",        CG3State, width,     -1),
> +    DEFINE_PROP_UINT16("height",       CG3State, height,    -1),
> +    DEFINE_PROP_UINT16("depth",        CG3State, depth,     -1),
> +    DEFINE_PROP_HEX64("prom_addr",     CG3State, prom_addr, -1),

...and hex64 types. Please use UINT32 and UINT64 instead.

> +    DEFINE_PROP_END_OF_LIST(),
> +};

And as far as QOM and style is concerned, please don't use TCX as excuse
to do things the old way. If you feel you need consistency, feel free to
clean up TCX, but we only require it for new patches. Otherwise no
progress would be possible within the code base.

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg