From: Hans Verkuil <hverkuil@xs4all.nl>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: fimc-lite.c: compile warning indicates bug
Date: Mon, 10 Feb 2014 10:00:19 +0100 [thread overview]
Message-ID: <52F89523.5030101@xs4all.nl> (raw)
In-Reply-To: <52CC124B.8060700@samsung.com>
On 01/07/2014 03:42 PM, Sylwester Nawrocki wrote:
> Hi Hans,
>
> On 07/01/14 14:32, Hans Verkuil wrote:
>> Hi Sylwester,
>>
>> I just did a quick build with the latest set of commits and I found this
>> warning:
>>
>> .../media-git/drivers/media/platform/exynos4-is/fimc-lite.c: In function 'fimc_lite_probe':
>> .../media-git/drivers/media/platform/exynos4-is/fimc-lite.c:1583:1: warning: label 'err_sd' defined but not used [-Wunused-label]
>> err_sd:
>> ^
>>
>> As far as I can tell err_sd should certainly be used to do proper cleanup.
>> Can you check the code and prepare a patch?
>
> Yes, I also noticed it in the media daily builds. It's a rebase error,
> unfortunately the mainline driver is now far behind our internal code.
> I will prepare a patch to fix this as soon as possible.
This is now the only warning left. Did you post a patch and did I miss it?
Regards,
Hans
prev parent reply other threads:[~2014-02-10 9:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 13:32 fimc-lite.c: compile warning indicates bug Hans Verkuil
2014-01-07 14:42 ` Sylwester Nawrocki
2014-02-10 9:00 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F89523.5030101@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.