Re: [PATCH 3/4] drivers: xen: Move prototype declaration to appropriate header file from arch/x86/xen/xen-ops.h

[David Vrabel <david.vrabel@citrix.com>]

On 09/02/14 11:08, Rashika Kheria wrote:
> Move prototype declaration to header file include/xen/xen-ops.h from
> arch/x86/xen/xen-ops.h because they are used by more than one file.
> 
> This eliminates the following warning in drivers/xen/events/:
> drivers/xen/events_2l.c:1231:13: warning: no previous prototype for ‘xen_debug_interrupt’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
[...]
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -2,6 +2,7 @@
>  #define INCLUDE_XEN_OPS_H
>  
>  #include <linux/percpu.h>
> +#include <linux/interrupt.h>
>  #include <asm/xen/interface.h>
>  
>  DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
> @@ -35,4 +36,6 @@ int xen_unmap_domain_mfn_range(struct vm_area_struct *vma,
>  			       int numpgs, struct page **pages);
>  
>  bool xen_running_on_version_or_later(unsigned int major, unsigned int minor);
> +
> +irqreturn_t xen_debug_interrupt(int irq, void *dev_id);

This should be moved to include/xen/events.h instead.

David