From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [OSSTEST PATCH] freebsd: switch to 10.0-RELEASE
	(20140116-r260789)
Date: Mon, 10 Feb 2014 15:34:33 +0100
Message-ID: <52F8E379.4020702@citrix.com>
References: <1392034392-27273-1-git-send-email-ian.jackson@eu.citrix.com>	<52F8C40E.7010707@citrix.com>
	<21240.50574.203262.432094@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <roger.pau@citrix.com>) id 1WCrwU-0006X1-Bq
	for xen-devel@lists.xenproject.org; Mon, 10 Feb 2014 14:34:38 +0000
In-Reply-To: <21240.50574.203262.432094@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 10/02/14 13:26, Ian Jackson wrote:
> Roger Pau Monn=E9 writes ("Re: [OSSTEST PATCH] freebsd: switch to 10.0-RE=
LEASE (20140116-r260789)"):
>> Thanks for the patch. I think it's missing the following chunk:
> ...
>> -our $freebsd_version=3D "10.0-BETA3";
>> +our $freebsd_version=3D "10.0-RELEASE";
> =

> Oh.  Err, why is this hardcoded in the script ?  Changing the
> runvar(s) ought to be sufficient.
> =

> ... (looks at the code) ...
> =

> Oh, I see, that's just the default.  Perhaps the default should be
> removed entirely ?  None of the other scripts have a default image
> filename.

So $freebsd_image is going to contain the absolute path to the image?
I'm asking because ts-freebsd-install searches for the image in
/var/images, do we have to do something like /var/images/$freebsd_image
in order to get the absolute image path?

Roger.