All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fb.com>
To: Filipe David Borba Manana <fdmanana@gmail.com>, <xfs@oss.sgi.com>
Cc: <linux-btrfs@vger.kernel.org>, <clm@fb.com>
Subject: Re: [PATCH] xfstests: add test for btrfs data corruption when using compression
Date: Mon, 10 Feb 2014 16:32:50 -0500	[thread overview]
Message-ID: <52F94582.6040703@fb.com> (raw)
In-Reply-To: <1391874609-19721-1-git-send-email-fdmanana@gmail.com>



On 02/08/2014 10:50 AM, Filipe David Borba Manana wrote:
> Test for a btrfs data corruption when using compressed files/extents.
> Under certain cases, it was possible for reads to return random data
> (content from a previously used page) instead of zeroes. This also
> caused partial updates to those regions that were supposed to be filled
> with zeroes to save random (and invalid) data into the file extents.
>
> This is fixed by the commit for the linux kernel titled:
>
>     Btrfs: fix data corruption when reading/updating compressed extents
>     (https://urldefense.proofpoint.com/v1/url?u=https://patchwork.kernel.org/patch/3610391/&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=cKCbChRKsMpTX8ybrSkonQ%3D%3D%0A&m=JRaF%2BUY%2F2k%2BBfF9nTx3Iwl5JZWNCwew%2BI%2Fw%2B%2BfuDrgc%3D%0A&s=4a033ea8f3cf1f28794e90fcf16ea553766bb1ea83e10fc904182a8f56435eef)
>

Ran with and without the corresponding fix and all worked as expected. 
You can add

Reviewed-by: Josef Bacik <jbacik@fb.com>

Thanks,

Josef

WARNING: multiple messages have this Message-ID (diff)
From: Josef Bacik <jbacik@fb.com>
To: Filipe David Borba Manana <fdmanana@gmail.com>, xfs@oss.sgi.com
Cc: clm@fb.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] xfstests: add test for btrfs data corruption when using compression
Date: Mon, 10 Feb 2014 16:32:50 -0500	[thread overview]
Message-ID: <52F94582.6040703@fb.com> (raw)
In-Reply-To: <1391874609-19721-1-git-send-email-fdmanana@gmail.com>



On 02/08/2014 10:50 AM, Filipe David Borba Manana wrote:
> Test for a btrfs data corruption when using compressed files/extents.
> Under certain cases, it was possible for reads to return random data
> (content from a previously used page) instead of zeroes. This also
> caused partial updates to those regions that were supposed to be filled
> with zeroes to save random (and invalid) data into the file extents.
>
> This is fixed by the commit for the linux kernel titled:
>
>     Btrfs: fix data corruption when reading/updating compressed extents
>     (https://urldefense.proofpoint.com/v1/url?u=https://patchwork.kernel.org/patch/3610391/&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=cKCbChRKsMpTX8ybrSkonQ%3D%3D%0A&m=JRaF%2BUY%2F2k%2BBfF9nTx3Iwl5JZWNCwew%2BI%2Fw%2B%2BfuDrgc%3D%0A&s=4a033ea8f3cf1f28794e90fcf16ea553766bb1ea83e10fc904182a8f56435eef)
>

Ran with and without the corresponding fix and all worked as expected. 
You can add

Reviewed-by: Josef Bacik <jbacik@fb.com>

Thanks,

Josef

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-02-10 21:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-08 15:50 [PATCH] xfstests: add test for btrfs data corruption when using compression Filipe David Borba Manana
2014-02-08 15:50 ` Filipe David Borba Manana
2014-02-10 21:32 ` Josef Bacik [this message]
2014-02-10 21:32   ` Josef Bacik
2014-02-17  0:35 ` [PATCH v2] " Filipe David Borba Manana
2014-02-17  0:35   ` Filipe David Borba Manana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F94582.6040703@fb.com \
    --to=jbacik@fb.com \
    --cc=clm@fb.com \
    --cc=fdmanana@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.