All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Mick <dan.mick@inktank.com>
To: Thomas Matysik <thomas@belton.co.nz>, stgt@vger.kernel.org
Subject: Re: [PATCH 1/2] Fix bs_rbd.c slurp_to_semi() not consuming terminating semicolon
Date: Mon, 10 Feb 2014 14:12:06 -0800	[thread overview]
Message-ID: <52F94EB6.3030701@inktank.com> (raw)
In-Reply-To: <1390356859-7557-1-git-send-email-thomas@belton.co.nz>

Reviewed-by: Dan Mick <dan.mick@inktank.com>

On 01/21/2014 06:14 PM, Thomas Matysik wrote:
> slurp_to_semi() would not consume the terminating semicolon on a
> option specified in --bsopts, so any options other than the first
> would be ignored as invalid.
>
> Signed-off-by: Thomas Matysik <thomas@belton.co.nz>
> ---
>   usr/bs_rbd.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/usr/bs_rbd.c b/usr/bs_rbd.c
> index 3ea9d36..f797fd5 100644
> --- a/usr/bs_rbd.c
> +++ b/usr/bs_rbd.c
> @@ -480,6 +480,9 @@ static char *slurp_to_semi(char **p)
>   	strncpy(ret, *p, len);
>   	ret[len] = '\0';
>   	*p = end;
> +	// Jump past the semicolon, if we stopped at one
> +	if (**p == ';')
> +		*p = end + 1;
>   	return ret;
>   }
>
>

  parent reply	other threads:[~2014-02-10 22:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-22  2:14 [PATCH 1/2] Fix bs_rbd.c slurp_to_semi() not consuming terminating semicolon Thomas Matysik
2014-01-22  2:14 ` [PATCH 2/2] Add "cluster" option to bs_rbd.c to specify cluster name Thomas Matysik
2014-02-10 22:12   ` Dan Mick
2014-02-11  0:16     ` FUJITA Tomonori
2014-01-24  5:13 ` [PATCH 1/2] Fix bs_rbd.c slurp_to_semi() not consuming terminating semicolon FUJITA Tomonori
2014-02-10 22:07   ` Dan Mick
2014-02-10 22:12 ` Dan Mick [this message]
2014-02-11  0:14   ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F94EB6.3030701@inktank.com \
    --to=dan.mick@inktank.com \
    --cc=stgt@vger.kernel.org \
    --cc=thomas@belton.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.