Re: [PATCH part1 v5 3/7] PCI: Add support for Device Serial Number capability

[Yijing Wang <wangyijing@huawei.com>]

On 2014/2/10 18:21, Oliver Neukum wrote:
> 
> On Mon, 2014-02-10 at 12:04 +0800, Yijing Wang wrote:
>> +static u64 pci_device_serial_number(struct pci_bus *bus, int devfn)
>> +{
>> +       int pos;
>> +       u32 lo, hi;
>> +
>> +       if (!pci_bus_find_capability(bus, devfn, PCI_CAP_ID_EXP))
>> +               return 0;
>> +
>> +       pos = pci_bus_find_ext_capability(bus, devfn,
>> PCI_EXT_CAP_ID_DSN);
>> +       if (!pos)
>> +               return 0;
>> +
>> +       pci_bus_read_config_dword(bus, devfn, pos + 4, &lo);
>> +       pci_bus_read_config_dword(bus, devfn, pos + 8, &hi);
> 
> We have no macro for that?

Yes, I will try to define macros for them, thanks!

> 
>> +       return ((u64)hi << 32) | lo;
>> +}
> 
> 	Regards
> 		Oliver
> 
> 
> 
> 
> .
> 


-- 
Thanks!
Yijing