From: Jaehoon Chung <jh80.chung@samsung.com>
To: Puthikorn Voravootivat <puthik@chromium.org>,
Chris Ball <chris@printf.net>,
Seungwon Jeon <tgih.jun@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: MMC list <linux-mmc@vger.kernel.org>,
Gwendal Grignou <gwendal@chromium.org>,
Grant Grundler <grundler@chromium.org>
Subject: Re: [PATCH v2] mmc: enable trim in eMMC device
Date: Tue, 11 Feb 2014 11:48:46 +0900 [thread overview]
Message-ID: <52F98F8E.9090906@samsung.com> (raw)
In-Reply-To: <1392072891-21302-1-git-send-email-puthik@chromium.org>
As my understanding, if erase will be used by default, MMC_CAP_ERASE flags can be removed. isn't?
Best Regards,
Jaehoon Chung
On 02/11/2014 07:54 AM, Puthikorn Voravootivat wrote:
> Force all host to have erase capacity to enable trim or
> discard feature in supported eMMC device.
>
> Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
> ---
> V2 change:
> Instead of add MMC_CAP_ERASE just only for dw_mmc, this patch adds
> this capability to all host.
>
> drivers/mmc/core/host.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index 49bc403..a21f590 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -521,6 +521,8 @@ int mmc_add_host(struct mmc_host *host)
> WARN_ON((host->caps & MMC_CAP_SDIO_IRQ) &&
> !host->ops->enable_sdio_irq);
>
> + host->caps |= MMC_CAP_ERASE;
> +
> err = device_add(&host->class_dev);
> if (err)
> return err;
>
prev parent reply other threads:[~2014-02-11 2:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 18:39 [PATCH] dw-mmc: enable trim in eMMC device Puthikorn Voravootivat
2014-02-10 4:07 ` Jaehoon Chung
2014-02-10 9:41 ` Ulf Hansson
2014-02-10 9:53 ` Jaehoon Chung
2014-02-10 19:53 ` Puthikorn Voravootivat
2014-02-10 22:54 ` [PATCH v2] mmc: " Puthikorn Voravootivat
2014-02-11 2:48 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F98F8E.9090906@samsung.com \
--to=jh80.chung@samsung.com \
--cc=chris@printf.net \
--cc=grundler@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-mmc@vger.kernel.org \
--cc=puthik@chromium.org \
--cc=tgih.jun@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.