All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arch-at91: Gets ethernet working on at91sam9g20 board
Date: Tue, 11 Feb 2014 08:24:19 +0100	[thread overview]
Message-ID: <52F9D023.5050105@googlemail.com> (raw)
In-Reply-To: <20140211025424.GA31651@vega.jjdev.com>

Dear johnd,

SoB line missing!

On 11.02.14 03:54, johnd wrote:
> ---
>  arch/arm/include/asm/arch-at91/at91_rstc.h |    2 +-
>  include/configs/at91sam9260ek.h            |    1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/asm/arch-at91/at91_rstc.h b/arch/arm/include/asm/arch-at91/at91_rstc.h
> index a942342..59be96b 100644
> --- a/arch/arm/include/asm/arch-at91/at91_rstc.h
> +++ b/arch/arm/include/asm/arch-at91/at91_rstc.h
> @@ -25,7 +25,7 @@ typedef struct at91_rstc {
>  
>  #endif /* __ASSEMBLY__ */
>  
> -#define AT91_RSTC_KEY		0xA5000000
> +#define AT91_RSTC_KEY		0xA5

This change is wrong, the RSTC key is located in RSTC_CR[31:24], your
change will move the constant to RSTC_CR[8:0]!

>  
>  #define AT91_RSTC_CR_PROCRST	0x00000001
>  #define AT91_RSTC_CR_PERRST	0x00000004
> diff --git a/include/configs/at91sam9260ek.h b/include/configs/at91sam9260ek.h
> index 73917b0..53bef35 100644
> --- a/include/configs/at91sam9260ek.h
> +++ b/include/configs/at91sam9260ek.h
> @@ -177,6 +177,7 @@
>  #define CONFIG_SYS_NO_FLASH			1
>  
>  /* Ethernet */
> +#define CONFIG_MACB_SEARCH_PHY

That change would be accepted, if the SoB line is available.

>  #define CONFIG_MACB			1
>  #define CONFIG_RMII			1
>  #define CONFIG_NET_RETRY_COUNT		20
> 

Best regards

Andreas Bie?mann

  reply	other threads:[~2014-02-11  7:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-11  2:54 [U-Boot] [PATCH] arch-at91: Gets ethernet working on at91sam9g20 board johnd
2014-02-11  7:24 ` Andreas Bießmann [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-03-06 20:33 John de la Garza
2014-03-07  7:20 ` Andreas Bießmann
2014-03-08 17:19 ` Gerhard Sittig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F9D023.5050105@googlemail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.