From mboxrd@z Thu Jan  1 00:00:00 1970
From: Emil Velikov <emil.l.velikov@gmail.com>
Subject: Re: [PATCHv2 4/4] pipe-loader: add pipe loader for freedreno/msm
Date: Tue, 11 Feb 2014 12:30:21 +0000
Message-ID: <52FA17DD.3070401@gmail.com>
References: <1392057261-25942-1-git-send-email-robdclark@gmail.com>	<1392057261-25942-5-git-send-email-robdclark@gmail.com>	<52F9A76A.6030600@gmail.com>
	<CAF6AEGuZsgKQrGfQ9fi=iknnt2MFF-+ukgZZfpP8UfUzrvVO+A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-we0-f182.google.com (mail-we0-f182.google.com
	[74.125.82.182])
	by gabe.freedesktop.org (Postfix) with ESMTP id 15AD0FA95D
	for <dri-devel@lists.freedesktop.org>;
	Tue, 11 Feb 2014 04:28:12 -0800 (PST)
Received: by mail-we0-f182.google.com with SMTP id u57so5580784wes.27
	for <dri-devel@lists.freedesktop.org>;
	Tue, 11 Feb 2014 04:28:12 -0800 (PST)
In-Reply-To: <CAF6AEGuZsgKQrGfQ9fi=iknnt2MFF-+ukgZZfpP8UfUzrvVO+A@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: Rob Clark <robdclark@gmail.com>
Cc: emil.l.velikov@gmail.com, Rob Clark <robclark@freedesktop.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

On 11/02/14 12:09, Rob Clark wrote:
> On Mon, Feb 10, 2014 at 11:30 PM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
>> On 10/02/14 18:34, Rob Clark wrote:
>>> From: Rob Clark <robclark@freedesktop.org>
>>>
>>> Signed-off-by: Rob Clark <robclark@freedesktop.org>
>>> ---
>>>  src/gallium/targets/pipe-loader/Makefile.am | 16 ++++++++++++++++
>>>  src/gallium/targets/pipe-loader/pipe_msm.c  | 21 +++++++++++++++++++++
>>>  2 files changed, 37 insertions(+)
>>>  create mode 100644 src/gallium/targets/pipe-loader/pipe_msm.c
>>>
>>> diff --git a/src/gallium/targets/pipe-loader/Makefile.am b/src/gallium/targets/pipe-loader/Makefile.am
>>> index 97733c1..8a0f254 100644
>>> --- a/src/gallium/targets/pipe-loader/Makefile.am
>>> +++ b/src/gallium/targets/pipe-loader/Makefile.am
>>> @@ -132,6 +132,22 @@ pipe_radeonsi_la_LDFLAGS += $(LLVM_LDFLAGS)
>>>  endif
>>>  endif
>>>
>>> +if HAVE_GALLIUM_FREEDRENO
>>> +pipe_LTLIBRARIES += pipe_msm.la
>>> +pipe_msm_la_SOURCES = pipe_msm.c
>>> +nodist_EXTRA_pipe_msm_la_SOURCES = dummy.cpp
>>> +pipe_msm_la_LIBADD = \
>>> +     $(PIPE_LIBS) \
>>> +     $(top_builddir)/src/gallium/winsys/freedreno/drm/libfreedrenodrm.la \
>>> +     $(top_builddir)/src/gallium/drivers/freedreno/libfreedreno.la \
>> Should have spotted this earlier, but it seems like you're forgot to
>> link against libdrm_freedreno ?
>>
>> + $(FREEDRENO_LIBS) \
> 
> hmm, good point.. I wonder why it works?
> 
Guessing that the linker favours us or there is a bug somewhere :)

>> -Emil