From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Olivier Sobrie <olivier@sobrie.be>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH] can: kvaser_usb: check number of channels returned by HW
Date: Tue, 11 Feb 2014 13:36:13 +0100 [thread overview]
Message-ID: <52FA193D.40205@pengutronix.de> (raw)
In-Reply-To: <20140211123218.GA8818@hposo>
[-- Attachment #1: Type: text/plain, Size: 1009 bytes --]
On 02/11/2014 01:33 PM, Olivier Sobrie wrote:
> Hello Marc,
>
> On Tue, Feb 11, 2014 at 11:09:57AM +0100, Marc Kleine-Budde wrote:
>> On 02/11/2014 11:01 AM, Olivier Sobrie wrote:
>>> It is needed to check the number of channels returned by the HW
>>> because it cannot be greater than MAX_NET_DEVICES otherwise
>>> it will crash.
>>>
>>> Signed-off-by: Olivier Sobrie <olivier@sobrie.be>
>>
>> Does this bug occur on any kvaser USB hardware?
>
> I never see it with the devices I have and nobody reported me a problem
> regarding this. I found this bug by chance while I was looking to add
> support for Kvaser device from usbcanII family.
Tnx, I'll include the patch in my next pull request to David.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
next prev parent reply other threads:[~2014-02-11 12:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 10:01 [PATCH] can: kvaser_usb: check number of channels returned by HW Olivier Sobrie
2014-02-11 10:09 ` Marc Kleine-Budde
2014-02-11 12:33 ` Olivier Sobrie
2014-02-11 12:36 ` Marc Kleine-Budde [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-12 10:35 pull-request: can 2014-02-12 Marc Kleine-Budde
2014-02-12 10:35 ` [PATCH] can: kvaser_usb: check number of channels returned by HW Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FA193D.40205@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=olivier@sobrie.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.