From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen: Don't use -nostdinc flags with CLANG Date: Tue, 11 Feb 2014 13:20:52 +0000 Message-ID: <52FA23B4.5060203@linaro.org> References: <1392074974-1488-1-git-send-email-julien.grall@linaro.org> <20140211085317.GB92054@deinos.phlegethon.org> <52FA17E3.9070105@linaro.org> <20140211123515.GD97288@deinos.phlegethon.org> <52FA1945.8010400@linaro.org> <20140211125928.GE97288@deinos.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WDDGi-00079F-2u for xen-devel@lists.xenproject.org; Tue, 11 Feb 2014 13:20:56 +0000 Received: by mail-wi0-f175.google.com with SMTP id hm4so4230577wib.8 for ; Tue, 11 Feb 2014 05:20:54 -0800 (PST) In-Reply-To: <20140211125928.GE97288@deinos.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: xen-devel@lists.xenproject.org, keir@xen.org, Ian.Jackson@eu.citrix.com, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 11/02/14 12:59, Tim Deegan wrote: > Are you using a very old version of clang? As 06a9c7e points out, > our current runes didn't work before clang v3.0. I'm using clang 3.5 (which have other issue to compile Xen), but I have also tried 3.0 and 3.3. > If not, rather than chasing this around any further, I think we should > abandon trying to use the compiler-provided headers even on linux. > Does this patch fix your build issue? > > commit e7003f174e0df9192dde6fa8d33b0a20f99ce053 > Author: Tim Deegan > Date: Tue Feb 11 12:44:09 2014 +0000 > > xen: stop trying to use the system and With this patch, -iwithprefix include is not necessary now. I wondering if we can remove it from the command line. > We already have our own versions of the stdarg/stdbool definitions, for > systems where those headers are installed in /usr/include. > > On linux, they're typically installed in compiler-specific paths, but > finding them has proved unreliable. Drop that and use our own versions > everywhere. > > Signed-off-by: Tim Deegan This patch is working fine to build xen clang 3.0, 3.3. I have others issue to build with clang 3.5. Tested-by: Julien Grall Thanks! -- Julien Grall