From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH 2/5] scsi: improved eh timeout handler Date: Tue, 11 Feb 2014 15:29:10 +0100 Message-ID: <52FA33B6.9010501@suse.de> References: <1384173897-103836-1-git-send-email-hare@suse.de> <1384173897-103836-3-git-send-email-hare@suse.de> <20140211140148.GA1897@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from cantor2.suse.de ([195.135.220.15]:46128 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105AbaBKO3N (ORCPT ); Tue, 11 Feb 2014 09:29:13 -0500 In-Reply-To: <20140211140148.GA1897@infradead.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Christoph Hellwig Cc: James Bottomley , linux-scsi@vger.kernel.org, Christoph Hellwig , Ren Mingxin , Joern Engel , James Smart On 02/11/2014 03:01 PM, Christoph Hellwig wrote: > Hi Hannes, >=20 > I'll need a little reminder how we came to the conclusion that the > cancel_delayed_work in scsi_put_command was safe and we didn't need > a cancel_delayed_work_sync or flush_delayed_work. I remember we had > that discussion, but it seems that same doesn't apply to the equivale= nt > call in the blk-mq codepath in my tree. If you remember anything tha= t > might make my life debugging this a bit easier. >=20 Well, _actually_ the cancel_delayed_work should be pointless; I've just added it as a terminal measure here. (It'd actually be an idea to insert a BUG_ON() here ...) Thing is whenever the eh_timeout thingie kicks in we most definitely know there's a command in flight, and hence scsi_command_put() should _never_ be called. Only after eh_abort has finished the command will be returned via scsi_command_put(), but then eh_abort is done for, too, and no item should remain in the workqueue. HTH. Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html