From: Dave Hansen <dave.hansen@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, dzickus@redhat.com,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] x86/nmi: Push duration printk() to irq context
Date: Tue, 11 Feb 2014 08:44:22 -0800 [thread overview]
Message-ID: <52FA5366.3020007@linux.intel.com> (raw)
In-Reply-To: <20140211150116.GO27965@twins.programming.kicks-ass.net>
On 02/11/2014 07:01 AM, Peter Zijlstra wrote:
> - irq_work_queue(&perf_duration_work);
> + if (!irq_work_queue(&perf_duration_work)) {
> + early_printk("perf interrupt took too long (%lld > %lld), lowering "
> + "kernel.perf_event_max_sample_rate to %d\n",
> + avg_local_sample_len, allowed_ns >> 1,
> + sysctl_perf_event_sample_rate);
> + }
> }
That's a cool trick. Works for me.
next prev parent reply other threads:[~2014-02-11 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 13:29 [tip:perf/core] x86/nmi: Push duration printk() to irq context tip-bot for Peter Zijlstra
2014-02-10 16:45 ` Dave Hansen
2014-02-10 17:05 ` Peter Zijlstra
2014-02-11 15:01 ` Peter Zijlstra
2014-02-11 16:44 ` Dave Hansen [this message]
2014-02-21 21:12 ` [tip:perf/core] perf/x86: Warn to early_printk() in case irq_work is too slow tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FA5366.3020007@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=dzickus@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.