From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Velikov Subject: Re: [PATCH] nv30,nvc0: only claim a single viewport Date: Tue, 11 Feb 2014 17:19:48 +0000 Message-ID: <52FA5BB4.5050704@gmail.com> References: <1392097346-7483-1-git-send-email-imirkin@alum.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1392097346-7483-1-git-send-email-imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: Ilia Mirkin , mesa-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org On 11/02/14 05:42, Ilia Mirkin wrote: > It should be possible to make this be 16 on nvc0. > > Signed-off-by: Ilia Mirkin Reviewed-by: Emil Velikov I have some other patches in the queue and I'll push this shortly -Emil > --- > > Not touching nv50 since I have a patch that actually impelents support for > multiple viewports there. > > src/gallium/drivers/nouveau/nv30/nv30_screen.c | 2 ++ > src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c b/src/gallium/drivers/nouveau/nv30/nv30_screen.c > index 8eee06b..c027a5f 100644 > --- a/src/gallium/drivers/nouveau/nv30/nv30_screen.c > +++ b/src/gallium/drivers/nouveau/nv30/nv30_screen.c > @@ -84,6 +84,8 @@ nv30_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param) > return 0; > case PIPE_CAP_CONSTANT_BUFFER_OFFSET_ALIGNMENT: > return 16; > + case PIPE_CAP_MAX_VIEWPORTS: > + return 1; > /* nv4x capabilities */ > case PIPE_CAP_BLEND_EQUATION_SEPARATE: > case PIPE_CAP_NPOT_TEXTURES: > diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c > index f84c41b..28d9be2 100644 > --- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c > +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c > @@ -175,6 +175,8 @@ nvc0_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param) > return PIPE_ENDIAN_LITTLE; > case PIPE_CAP_TGSI_VS_LAYER: > return 0; > + case PIPE_CAP_MAX_VIEWPORTS: > + return 1; > default: > NOUVEAU_ERR("unknown PIPE_CAP %d\n", param); > return 0; >