From: Dinh Nguyen <dinh.linux@gmail.com>
To: Jingoo Han <jg1.han@samsung.com>,
'Stephen Warren' <swarren@wwwdotorg.org>,
dinguyen@altera.com, linux-usb@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org,
'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>,
'Paul Zimmerman' <paulz@synopsys.com>,
'Felipe Balbi' <balbi@ti.com>, 'Ben Dooks' <ben-linux@fluff.org>,
'Matt Porter' <mporter@linaro.org>,
'Kukjin Kim' <kgene.kim@samsung.com>,
'Matthijs Kooijman' <matthijs@stdin.nl>,
'Fengguang Wu' <fengguang.wu@intel.com>,
'Dan Carpenter' <dan.carpenter@oracle.com>,
'Wei Yongjun' <yongjun_wei@trendmicro.com.cn>,
'Wolfram Sang' <wsa@the-dreams.de>,
'Yijing Wang' <wangyijing@huawei.com>,
'Ray Jui' <rjui@broadcom.com>,
'Julien Delacou' <julien.delacou@stericsson.com>,
'Dom Cobley' <popcornmix@gmail.com>,
'Rashika Kheria' <rashika.kheria@gmail.com>,
'Sachin Kamat' <sachin.kamat@linaro.org>,
'Robert Baldyga' <r.baldyga@samsung.com>,
'Kishon Vijay Abraham I' <kishon@ti.com>
Subject: Re: [RFC PATCHv1] usb: dwc2: Combine the dwc2 and s3c_hsotg into a single USB DRD driver.
Date: Wed, 12 Feb 2014 00:17:38 -0600 [thread overview]
Message-ID: <52FB1202.8040506@gmail.com> (raw)
In-Reply-To: <000401cf27b7$25114160$6f33c420$%han@samsung.com>
On 2/11/14 11:56 PM, Jingoo Han wrote:
> On Wednesday, February 12, 2014 2:34 PM, Stephen Warren wrote:
>> On 02/04/2014 02:45 PM, dinguyen@altera.com wrote:
>>> From: Dinh Nguyen <dinguyen@altera.com>
>>>
>>> This means that the driver can be in host or peripheral mode when the appropriate
>>> connector is used. When an A-cable is plugged in, the driver behaves in host
>>> mode, and when a B-cable is used, the driver will be in peripheral mode.
>> Sorry for the slow response. When building ARCH=arm bcm2835_defconfig, I
>> get build errors:
Thanks for testing.
>>
>>> drivers/built-in.o: In function `dwc2_gadget_init':
>>> drivers/usb/dwc2/s3c-hsotg.c:3335: undefined reference to `usb_add_gadget_udc'
>>> drivers/built-in.o: In function `s3c_hsotg_remove':
>>> drivers/usb/dwc2/s3c-hsotg.c:3358: undefined reference to `usb_del_gadget_udc'
>>> drivers/usb/dwc2/s3c-hsotg.c:3364: undefined reference to `usb_gadget_unregister_driver'
> These errors happen when CONFIG_USB_GADGET=n. 's3c-hsotg.c'
> supports only gadget mode. In the case of USB_DWC2_HOST mode,
> CONFIG_USB_GADGET is NOT enabled. I don't know how to solve it.
I'm working on v2 of this patch. I think I can make the Kconfig more
flexible by selecting
USB_GADGET for dual-role or gadget. Or I can make the new driver more
independent
for the various modes, meaning if the driver is built for HOST mode, it
shouldn't be dependent
on gadget functions.
Dinh
>
> Best regards,
> Jingoo Han
>
prev parent reply other threads:[~2014-02-12 6:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 21:45 [RFC PATCHv1] usb: dwc2: Combine dwc2/s3c-hsotg into a single DRD dinguyen-EIB2kfCEclfQT0dZR+AlfA
[not found] ` <1391550341-32509-1-git-send-email-dinguyen-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>
2014-02-04 21:45 ` [RFC PATCHv1] usb: dwc2: Combine the dwc2 and s3c_hsotg into a single USB DRD driver dinguyen-EIB2kfCEclfQT0dZR+AlfA
[not found] ` <1391550341-32509-2-git-send-email-dinguyen-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>
2014-02-05 0:42 ` Paul Zimmerman
2014-02-05 6:14 ` Dinh Nguyen
2014-02-05 19:20 ` Paul Zimmerman
2014-02-06 3:23 ` Jingoo Han
2014-02-12 5:34 ` Stephen Warren
2014-02-12 5:56 ` Jingoo Han
2014-02-12 6:17 ` Dinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FB1202.8040506@gmail.com \
--to=dinh.linux@gmail.com \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=dan.carpenter@oracle.com \
--cc=dinguyen@altera.com \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=julien.delacou@stericsson.com \
--cc=kgene.kim@samsung.com \
--cc=kishon@ti.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthijs@stdin.nl \
--cc=mporter@linaro.org \
--cc=paulz@synopsys.com \
--cc=popcornmix@gmail.com \
--cc=r.baldyga@samsung.com \
--cc=rashika.kheria@gmail.com \
--cc=rjui@broadcom.com \
--cc=sachin.kamat@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=wangyijing@huawei.com \
--cc=wsa@the-dreams.de \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.