From: Michal Simek <monstr@monstr.eu>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 07/11] watchdog: xilinx: Use of_property_read_u32
Date: Wed, 12 Feb 2014 09:13:23 +0100 [thread overview]
Message-ID: <52FB2D23.7090200@monstr.eu> (raw)
In-Reply-To: <20140211202038.GC11798@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 926 bytes --]
On 02/11/2014 09:20 PM, Guenter Roeck wrote:
> On Tue, Feb 11, 2014 at 07:55:50AM +0100, Michal Simek wrote:
>> Use of_property_read_u32 functions to clean probe function.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
> [ ... ]
>
>> +
>> + if (enable_once)
>> watchdog_set_nowayout(xilinx_wdt_wdd, true);
>> - }
>
> watchdog_set_nowayout(xilinx_wdt_wdd, enable_once);
>
> would probably do as well (the function checks the flag as well).
>
> Nitpick, so
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
I will change it and send v3.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: monstr@monstr.eu (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 07/11] watchdog: xilinx: Use of_property_read_u32
Date: Wed, 12 Feb 2014 09:13:23 +0100 [thread overview]
Message-ID: <52FB2D23.7090200@monstr.eu> (raw)
In-Reply-To: <20140211202038.GC11798@roeck-us.net>
On 02/11/2014 09:20 PM, Guenter Roeck wrote:
> On Tue, Feb 11, 2014 at 07:55:50AM +0100, Michal Simek wrote:
>> Use of_property_read_u32 functions to clean probe function.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
> [ ... ]
>
>> +
>> + if (enable_once)
>> watchdog_set_nowayout(xilinx_wdt_wdd, true);
>> - }
>
> watchdog_set_nowayout(xilinx_wdt_wdd, enable_once);
>
> would probably do as well (the function checks the flag as well).
>
> Nitpick, so
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
I will change it and send v3.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140212/379eaea2/attachment.sig>
next prev parent reply other threads:[~2014-02-12 8:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 6:55 [PATCH v2 01/11] watchdog: xilinx: Convert driver to the watchdog framework Michal Simek
2014-02-11 6:55 ` Michal Simek
2014-02-11 6:55 ` [PATCH v2 02/11] watchdog: xilinx: Move control_status_reg to functions Michal Simek
2014-02-11 6:55 ` Michal Simek
2014-02-11 6:55 ` [PATCH v2 03/11] watchdog: xilinx: Simplify probe and remove functions Michal Simek
2014-02-11 6:55 ` Michal Simek
2014-02-11 6:55 ` [PATCH v2 04/11] watchdog: xilinx: Move no_timeout to probe function Michal Simek
2014-02-11 6:55 ` Michal Simek
2014-02-11 6:55 ` [PATCH v2 05/11] watchdog: xilinx: Allocate private structure per device Michal Simek
2014-02-11 6:55 ` Michal Simek
2014-02-11 6:55 ` [PATCH v2 06/11] watchdog: xilinx: Fix all printk messages Michal Simek
2014-02-11 6:55 ` Michal Simek
2014-02-11 6:55 ` [PATCH v2 07/11] watchdog: xilinx: Use of_property_read_u32 Michal Simek
2014-02-11 6:55 ` Michal Simek
2014-02-11 20:20 ` Guenter Roeck
2014-02-11 20:20 ` Guenter Roeck
2014-02-11 20:20 ` Guenter Roeck
2014-02-12 8:13 ` Michal Simek [this message]
2014-02-12 8:13 ` Michal Simek
2014-02-11 6:55 ` [PATCH v2 08/11] watchdog: xilinx: Use correct comment indentation Michal Simek
2014-02-11 6:55 ` Michal Simek
2014-02-11 6:55 ` [PATCH v2 09/11] watchdog: xilinx: Add missing binding Michal Simek
2014-02-11 6:55 ` Michal Simek
2014-02-11 6:55 ` [PATCH v2 10/11] watchdog: xilinx: Enable this driver for Zynq Michal Simek
2014-02-11 6:55 ` [PATCH v2 11/11] watchdog: xilinx: Remove no_timeout variable Michal Simek
2014-02-11 6:55 ` Michal Simek
2014-02-11 20:17 ` Guenter Roeck
2014-02-11 20:17 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FB2D23.7090200@monstr.eu \
--to=monstr@monstr.eu \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.