From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Qin Chuanyu <qinchuanyu@huawei.com>
Cc: rusty@rustcorp.com.au, jasowang@redhat.com,
KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH] virtio: make udp more efficient by avoiding indirect desc
Date: Wed, 12 Feb 2014 09:59:26 +0100 [thread overview]
Message-ID: <52FB37EE.1090208@redhat.com> (raw)
In-Reply-To: <20140211154308.GA467@redhat.com>
Il 11/02/2014 16:43, Michael S. Tsirkin ha scritto:
>> > Signed-off-by: Chuanyu Qin <qinchuanyu@huawei.com>
> Optimization patch without any performance data?
> Such a change would need much more testing than that:
> would have to try various workloads with -net and -blk at least.
>
-blk and -scsi never use 2 descriptors except for flushes (which go all
the way to the platters or flash, and are not as frequent as other I/O).
So the patch is in all likelihood a no-op there.
Of course, virtio-net does need data.
Paolo
next prev parent reply other threads:[~2014-02-12 8:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 14:58 [PATCH] virtio: make udp more efficient by avoiding indirect desc Qin Chuanyu
2014-02-11 15:43 ` Michael S. Tsirkin
2014-02-12 1:51 ` Qin Chuanyu
2014-02-12 8:59 ` Paolo Bonzini [this message]
2014-03-03 11:22 ` Qin Chuanyu
2014-02-13 2:57 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FB37EE.1090208@redhat.com \
--to=pbonzini@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qinchuanyu@huawei.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.