All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Kumar Gala <galak@codeaurora.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] hwrng: msm: switch Kconfig to ARCH_QCOM depends
Date: Wed, 12 Feb 2014 11:33:14 +0200	[thread overview]
Message-ID: <52FB3FDA.4060307@mm-sol.com> (raw)
In-Reply-To: <1392150105-21057-1-git-send-email-galak@codeaurora.org>

Hi,
> We've split Qualcomm MSM support into legacy and multiplatform.  The RNG
> driver is only relevant on the multiplatform supported SoCs so switch the
> Kconfig depends to ARCH_QCOM.
> 
> CC: Herbert Xu <herbert@gondor.apana.org.au>
> Signed-off-by: Kumar Gala <galak@codeaurora.org>
> ---
>  drivers/char/hw_random/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> index 2f2b084..289bd3a 100644
> --- a/drivers/char/hw_random/Kconfig
> +++ b/drivers/char/hw_random/Kconfig
> @@ -343,7 +343,7 @@ config HW_RANDOM_TPM
>  
>  config HW_RANDOM_MSM
>  	tristate "Qualcomm MSM Random Number Generator support"
> -	depends on HW_RANDOM && ARCH_MSM
> +	depends on HW_RANDOM && ARCH_QCOM
>  	---help---
>  	  This driver provides kernel-side support for the Random Number
>  	  Generator hardware found on Qualcomm MSM SoCs.
> 

IMO, after this change the "MSM" abbreviation in help clause is
irrelevant, could you remove it?

Reviewed-by: Stanimir Varbanov <svarbanov@mm-sol.com>

regards,
Stan

WARNING: multiple messages have this Message-ID (diff)
From: svarbanov@mm-sol.com (Stanimir Varbanov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] hwrng: msm: switch Kconfig to ARCH_QCOM depends
Date: Wed, 12 Feb 2014 11:33:14 +0200	[thread overview]
Message-ID: <52FB3FDA.4060307@mm-sol.com> (raw)
In-Reply-To: <1392150105-21057-1-git-send-email-galak@codeaurora.org>

Hi,
> We've split Qualcomm MSM support into legacy and multiplatform.  The RNG
> driver is only relevant on the multiplatform supported SoCs so switch the
> Kconfig depends to ARCH_QCOM.
> 
> CC: Herbert Xu <herbert@gondor.apana.org.au>
> Signed-off-by: Kumar Gala <galak@codeaurora.org>
> ---
>  drivers/char/hw_random/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> index 2f2b084..289bd3a 100644
> --- a/drivers/char/hw_random/Kconfig
> +++ b/drivers/char/hw_random/Kconfig
> @@ -343,7 +343,7 @@ config HW_RANDOM_TPM
>  
>  config HW_RANDOM_MSM
>  	tristate "Qualcomm MSM Random Number Generator support"
> -	depends on HW_RANDOM && ARCH_MSM
> +	depends on HW_RANDOM && ARCH_QCOM
>  	---help---
>  	  This driver provides kernel-side support for the Random Number
>  	  Generator hardware found on Qualcomm MSM SoCs.
> 

IMO, after this change the "MSM" abbreviation in help clause is
irrelevant, could you remove it?

Reviewed-by: Stanimir Varbanov <svarbanov@mm-sol.com>

regards,
Stan

  reply	other threads:[~2014-02-12  9:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-11 20:21 [PATCH] hwrng: msm: switch Kconfig to ARCH_QCOM depends Kumar Gala
2014-02-11 20:21 ` Kumar Gala
2014-02-12  9:33 ` Stanimir Varbanov [this message]
2014-02-12  9:33   ` Stanimir Varbanov
2014-02-25 12:16   ` Herbert Xu
2014-02-25 12:16     ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FB3FDA.4060307@mm-sol.com \
    --to=svarbanov@mm-sol.com \
    --cc=galak@codeaurora.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.