From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out-135.synserver.de ([212.40.185.135]:1252 "EHLO smtp-out-003.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751881AbaBLMv0 (ORCPT ); Wed, 12 Feb 2014 07:51:26 -0500 Message-ID: <52FB6E52.3050108@metafoo.de> Date: Wed, 12 Feb 2014 13:51:30 +0100 From: Lars-Peter Clausen MIME-Version: 1.0 To: Mark Rutland CC: Paul Cercueil , Jonathan Cameron , "linux-iio@vger.kernel.org" , "rob.herring@calxeda.com" , Pawel Moll , Ian Campbell , Kumar Gala , Rob Landley , "devicetree@vger.kernel.org" Subject: Re: [PATCH] devicetree: ad7303: Updated documentation References: <1392206903-1662-1-git-send-email-paul.cercueil@analog.com> <20140212122137.GA25957@e106331-lin.cambridge.arm.com> In-Reply-To: <20140212122137.GA25957@e106331-lin.cambridge.arm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 02/12/2014 01:21 PM, Mark Rutland wrote: > On Wed, Feb 12, 2014 at 12:08:23PM +0000, Paul Cercueil wrote: >> Added documentation about the "adi,use-external-reference" >> property. >> >> Signed-off-by: Paul Cercueil >> --- >> Documentation/devicetree/bindings/iio/dac/ad7303.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iio/dac/ad7303.txt b/Documentation/devicetree/bindings/iio/dac/ad7303.txt >> index 914610f..de6b32f 100644 >> --- a/Documentation/devicetree/bindings/iio/dac/ad7303.txt >> +++ b/Documentation/devicetree/bindings/iio/dac/ad7303.txt >> @@ -7,6 +7,9 @@ Required properties: >> - Vdd-supply: Phandle to the Vdd power supply >> >> Optional properties: >> + - adi,use-external-reference: If set, the external reference voltage >> + supply is used. Otherwise, the internal reference voltage supply is >> + used. > > As I asked for the ad5064 binding document, when would you want to do > this, and why can't the driver decide? Hi, sorry my fault. I got confused with an older version of this driver and the version that actually made it upstream. This property is not in the upstream driver. The patch can safely be ignored and go to /dev/null. Again, sorry for noise. - Lars From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH] devicetree: ad7303: Updated documentation Date: Wed, 12 Feb 2014 13:51:30 +0100 Message-ID: <52FB6E52.3050108@metafoo.de> References: <1392206903-1662-1-git-send-email-paul.cercueil@analog.com> <20140212122137.GA25957@e106331-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140212122137.GA25957-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Rutland Cc: Paul Cercueil , Jonathan Cameron , "linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , Pawel Moll , Ian Campbell , Kumar Gala , Rob Landley , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On 02/12/2014 01:21 PM, Mark Rutland wrote: > On Wed, Feb 12, 2014 at 12:08:23PM +0000, Paul Cercueil wrote: >> Added documentation about the "adi,use-external-reference" >> property. >> >> Signed-off-by: Paul Cercueil >> --- >> Documentation/devicetree/bindings/iio/dac/ad7303.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iio/dac/ad7303.txt b/Documentation/devicetree/bindings/iio/dac/ad7303.txt >> index 914610f..de6b32f 100644 >> --- a/Documentation/devicetree/bindings/iio/dac/ad7303.txt >> +++ b/Documentation/devicetree/bindings/iio/dac/ad7303.txt >> @@ -7,6 +7,9 @@ Required properties: >> - Vdd-supply: Phandle to the Vdd power supply >> >> Optional properties: >> + - adi,use-external-reference: If set, the external reference voltage >> + supply is used. Otherwise, the internal reference voltage supply is >> + used. > > As I asked for the ad5064 binding document, when would you want to do > this, and why can't the driver decide? Hi, sorry my fault. I got confused with an older version of this driver and the version that actually made it upstream. This property is not in the upstream driver. The patch can safely be ignored and go to /dev/null. Again, sorry for noise. - Lars