All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Lynch <Nathan_Lynch@mentor.com>
To: Benoit Cousson <bcousson@baylibre.com>, linux-omap@vger.kernel.org
Cc: tony@atomide.com
Subject: Re: [PATCH] ARM: dts: OMAP5: add pmu node
Date: Wed, 12 Feb 2014 09:02:25 -0600	[thread overview]
Message-ID: <52FB8D01.7030609@mentor.com> (raw)
In-Reply-To: <52FB7072.5000005@baylibre.com>

On 02/12/2014 07:00 AM, Benoit Cousson wrote:
>> On 01/29/2014 10:56 AM, Nathan Lynch wrote:
>>> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
>>> index a72813a9663e..fbf4661436e2 100644
>>> --- a/arch/arm/boot/dts/omap5.dtsi
>>> +++ b/arch/arm/boot/dts/omap5.dtsi
>>> @@ -76,6 +76,12 @@
>>>                    <GIC_PPI 10 (GIC_CPU_MASK_RAW(3) |
>>> IRQ_TYPE_LEVEL_LOW)>;
>>>       };
>>>
>>> +    pmu {
>>> +        compatible = "arm,cortex-a15-pmu";
>>> +        interrupts = <0 131 4>,
>>> +                 <0 132 4>;
> 
> Could you use the macros instead of hard coded value? You have the
> example just before your modification in the patch itself.

Thanks Benoit.  Sorry for missing that, will fix.


      reply	other threads:[~2014-02-12 15:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-29 16:56 [PATCH] ARM: dts: OMAP5: add pmu node Nathan Lynch
2014-01-29 16:56 ` Nathan Lynch
2014-02-11 20:14 ` Nathan Lynch
2014-02-12 13:00   ` Benoit Cousson
2014-02-12 15:02     ` Nathan Lynch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FB8D01.7030609@mentor.com \
    --to=nathan_lynch@mentor.com \
    --cc=bcousson@baylibre.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.