From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [PATCH v2 09/10] hw/mips: malta: Add KVM support Date: Wed, 12 Feb 2014 15:07:52 +0000 Message-ID: <52FB8E48.3080202@imgtec.com> References: <1387203165-5553-1-git-send-email-james.hogan@imgtec.com> <1387203165-5553-10-git-send-email-james.hogan@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Gleb Natapov , QEMU Developers , Sanjay Lal , Paolo Bonzini , Aurelien Jarno To: Peter Maydell Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 21/12/13 20:42, Peter Maydell wrote: > On 16 December 2013 14:12, James Hogan wrote: >> +#include "linux/kvm.h" > > You can't include linux/kvm.h like this -- on Linux this will pull in > whatever the host's system kvm.h happens to be, and on non-Linux > it won't compile: > > /Users/pm215/src/qemu/hw/mips/mips_malta.c:56:10: fatal error: > 'linux/kvm.h' file not found > #include "linux/kvm.h" > ^ > 1 error generated. Thanks Peter, I've removed all these new includes except sysemu/kvm.h. Cheers James From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDbPu-0005OP-Ms for qemu-devel@nongnu.org; Wed, 12 Feb 2014 10:08:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDbPp-00006a-45 for qemu-devel@nongnu.org; Wed, 12 Feb 2014 10:08:02 -0500 Received: from multi.imgtec.com ([194.200.65.239]:39704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDbPo-000061-Tk for qemu-devel@nongnu.org; Wed, 12 Feb 2014 10:07:57 -0500 Message-ID: <52FB8E48.3080202@imgtec.com> Date: Wed, 12 Feb 2014 15:07:52 +0000 From: James Hogan MIME-Version: 1.0 References: <1387203165-5553-1-git-send-email-james.hogan@imgtec.com> <1387203165-5553-10-git-send-email-james.hogan@imgtec.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 09/10] hw/mips: malta: Add KVM support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: kvm-devel , Gleb Natapov , QEMU Developers , Sanjay Lal , Paolo Bonzini , Aurelien Jarno On 21/12/13 20:42, Peter Maydell wrote: > On 16 December 2013 14:12, James Hogan wrote: >> +#include "linux/kvm.h" > > You can't include linux/kvm.h like this -- on Linux this will pull in > whatever the host's system kvm.h happens to be, and on non-Linux > it won't compile: > > /Users/pm215/src/qemu/hw/mips/mips_malta.c:56:10: fatal error: > 'linux/kvm.h' file not found > #include "linux/kvm.h" > ^ > 1 error generated. Thanks Peter, I've removed all these new includes except sysemu/kvm.h. Cheers James