All of lore.kernel.org
 help / color / mirror / Atom feed
From: fabrice.gasnier@st.com (Fabrice Gasnier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: Add imprecise abort enable/disable macro
Date: Wed, 12 Feb 2014 16:14:27 +0100	[thread overview]
Message-ID: <52FB8FD3.1020407@st.com> (raw)
In-Reply-To: <20140212131834.GP26684@n2100.arm.linux.org.uk>

Hi Russell,

On 02/12/2014 02:18 PM, Russell King - ARM Linux wrote:
> On Wed, Feb 12, 2014 at 02:05:39PM +0100, Fabrice GASNIER wrote:
>> Hi,
>>
>> Any comments on this patch ?
>>
>> Russell, can I add this patch to your patch tracker system ?
> I don't see how this works on anything but ARMv7M.

Sorry, i'm confused.

In the first patch you proposed,
http://archive.arm.linux.org.uk/lurker/message/20140131.170827.d752a1cc.en.html
there was :

#ifndef CONFIG_CPU_V7M

[...]

/* Enable imprecise aborts */
[...]

#else /* ifndef CONFIG_CPU_V7M */

I understand that abort handling (vectors and masking ?) is different on 
armv7-m ?
Or should we make no distinction ?

I have kept the same principle regarding abort enable/disable macro.

#if __LINUX_ARM_ARCH__ >= 6
[...]

#ifndef CONFIG_CPU_V7M
#define local_abt_enable()  __asm__("cpsie a    @ __sta" : : : "memory", 
"cc")
#define local_abt_disable() __asm__("cpsid a    @ __cla" : : : "memory", 
"cc")
#else
#define local_abt_enable()    do { } while (0)
#define local_abt_disable()    do { } while (0)
#endif

#else
[...]
#define local_abt_enable()    do { } while (0)
#define local_abt_disable()    do { } while (0)
#endif

Sorry if this is silly question ...

BR,
Fabrice
>

WARNING: multiple messages have this Message-ID (diff)
From: Fabrice Gasnier <fabrice.gasnier@st.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Fabrice GASNIER <fabrice.gasnier@stericsson.com>
Cc: <u.kleine-koenig@pengutronix.de>, <jonathan.austin@arm.com>,
	<catalin.marinas@arm.com>, <will.deacon@arm.com>,
	<nico@linaro.org>, <sboyd@codeaurora.org>, <marc.zyngier@arm.com>,
	<ben.dooks@codethink.co.uk>, <vgupta@synopsys.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <maxime.coquelin@st.com>
Subject: Re: [PATCH v2] ARM: Add imprecise abort enable/disable macro
Date: Wed, 12 Feb 2014 16:14:27 +0100	[thread overview]
Message-ID: <52FB8FD3.1020407@st.com> (raw)
In-Reply-To: <20140212131834.GP26684@n2100.arm.linux.org.uk>

Hi Russell,

On 02/12/2014 02:18 PM, Russell King - ARM Linux wrote:
> On Wed, Feb 12, 2014 at 02:05:39PM +0100, Fabrice GASNIER wrote:
>> Hi,
>>
>> Any comments on this patch ?
>>
>> Russell, can I add this patch to your patch tracker system ?
> I don't see how this works on anything but ARMv7M.

Sorry, i'm confused.

In the first patch you proposed,
http://archive.arm.linux.org.uk/lurker/message/20140131.170827.d752a1cc.en.html
there was :

#ifndef CONFIG_CPU_V7M

[...]

/* Enable imprecise aborts */
[...]

#else /* ifndef CONFIG_CPU_V7M */

I understand that abort handling (vectors and masking ?) is different on 
armv7-m ?
Or should we make no distinction ?

I have kept the same principle regarding abort enable/disable macro.

#if __LINUX_ARM_ARCH__ >= 6
[...]

#ifndef CONFIG_CPU_V7M
#define local_abt_enable()  __asm__("cpsie a    @ __sta" : : : "memory", 
"cc")
#define local_abt_disable() __asm__("cpsid a    @ __cla" : : : "memory", 
"cc")
#else
#define local_abt_enable()    do { } while (0)
#define local_abt_disable()    do { } while (0)
#endif

#else
[...]
#define local_abt_enable()    do { } while (0)
#define local_abt_disable()    do { } while (0)
#endif

Sorry if this is silly question ...

BR,
Fabrice
>


  reply	other threads:[~2014-02-12 15:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10 16:45 [PATCH v2] ARM: Add imprecise abort enable/disable macro Fabrice GASNIER
2014-02-10 16:45 ` Fabrice GASNIER
2014-02-12 13:05 ` Fabrice GASNIER
2014-02-12 13:05   ` Fabrice GASNIER
2014-02-12 13:18   ` Russell King - ARM Linux
2014-02-12 13:18     ` Russell King - ARM Linux
2014-02-12 15:14     ` Fabrice Gasnier [this message]
2014-02-12 15:14       ` Fabrice Gasnier
2014-02-17 12:57     ` Fabrice Gasnier
2014-02-17 12:57       ` Fabrice Gasnier
2014-02-12 13:07 ` Fabrice Gasnier
2014-02-12 13:07   ` Fabrice Gasnier
2014-11-17 17:37 ` Lucas Stach
2014-11-17 17:37   ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FB8FD3.1020407@st.com \
    --to=fabrice.gasnier@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.