From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] QMP: Allow dot separated dict path arguments in qmp-shell
Date: Wed, 12 Feb 2014 11:14:48 -0700 [thread overview]
Message-ID: <52FBBA18.8070104@redhat.com> (raw)
In-Reply-To: <1392174313-25921-1-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
On 02/11/2014 08:05 PM, Fam Zheng wrote:
> As another convinience to allow using commands that expect a dict as
You missed this, even though I pointed it out in v2:
s/convinience/convenience/
> argument, this patch adds support for foo.bar=value syntax, similar to
> command line argument style:
>
> (QEMU) blockdev-add options.driver=file options.id=drive1 options.filename=...
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> ---
My python is weak, so take this with a grain of salt:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-02-12 18:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 3:05 [Qemu-devel] [PATCH v3] QMP: Allow dot separated dict path arguments in qmp-shell Fam Zheng
2014-02-12 18:14 ` Eric Blake [this message]
2014-02-13 1:44 ` Fam Zheng
2014-02-14 9:47 ` Stefan Hajnoczi
2014-02-27 15:35 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FBBA18.8070104@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=imammedo@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.