All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Russell King - ARM Linux
	<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	linux-tegra <linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/2] ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig
Date: Wed, 12 Feb 2014 13:17:13 -0700	[thread overview]
Message-ID: <52FBD6C9.2010905@wwwdotorg.org> (raw)
In-Reply-To: <CAK5ve-+bzLkdwmab9sZGPk7p67ktVcK3mHQ2aUgMueH061ty6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 02/12/2014 01:09 PM, Bryan Wu wrote:
> On Wed, Feb 12, 2014 at 11:08 AM, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:
>> On 02/07/2014 04:54 PM, Bryan Wu wrote:
>>> PCA9546 is used in Cardhu Tegra30 board to connect to 3 cameras.
>>> Enabling this driver for Tegra V4L2 soc camera driver and camera
>>> sensor drivers.
>>
>> I've squashed patch 1/2 into Tegra's for-3.15/defconfig branch, and
>> applied patch 2/2 to Tegra's for-3.15/dt branch.
>>
>> Note that your patches were sent with an email "From" address that
>> didn't match your signed-off-by tag, yet "git send-email" didn't insert
>> a "From" header in the email body. Can you please check your git user ID
>> and/or email settings. Consequently, I had to adjust the git author
>> field in git to match your s-o-b line.
> 
> My bad. I need to update my git send-email script to use --from "Bryan
> Wu <pengw-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>" instead of --from "Bryan Wu
> <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>"
> 
> Need I resubmit this patchset?

No need to resent; I fixed them up.

Why not just put the correct values in ~/.gitconfig?

Perhaps this is because you switch between NVIDIA and non-NVIDIA email
addresses and/or mail servers, so you can't make ~/.gitconfig static and
universally correct? If you have a recent enough git, what I do is:

$ cat ~/.gitconfig
[include]
        path = .gitconfig-user
        path = .gitconfig-email-server
...

$ cat ~/.gitconfig-user-nvidia
[user]
	name = Stephen Warren
	email = swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

$ cat ~/.gitconfig-user-wwwdotorg
[user]
	name = Stephen Warren
	email = swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org

~/.gitconfig-user is a symlink to one of ~/.gitconfig-user-*, and I have
a script that deletes the link and points it at a new location:

$ cat `which git-switch-user`
#!/bin/bash

cd $HOME
mainfile=.gitconfig-user
newlink=${mainfile}-$1
if [ ! -f ${newlink} ]; then
    echo ERROR: ${newlink} not found
    exit 1
fi

rm -f ${mainfile}
ln -s ${newlink} ${mainfile}

... and the same thing for email servers.

Then, I can run e.g.:

git-switch-email-server nvidia; \
git send-email --to internal-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org *.patch; \
git-switch-email-server severn-port-forwarded

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig
Date: Wed, 12 Feb 2014 13:17:13 -0700	[thread overview]
Message-ID: <52FBD6C9.2010905@wwwdotorg.org> (raw)
In-Reply-To: <CAK5ve-+bzLkdwmab9sZGPk7p67ktVcK3mHQ2aUgMueH061ty6w@mail.gmail.com>

On 02/12/2014 01:09 PM, Bryan Wu wrote:
> On Wed, Feb 12, 2014 at 11:08 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 02/07/2014 04:54 PM, Bryan Wu wrote:
>>> PCA9546 is used in Cardhu Tegra30 board to connect to 3 cameras.
>>> Enabling this driver for Tegra V4L2 soc camera driver and camera
>>> sensor drivers.
>>
>> I've squashed patch 1/2 into Tegra's for-3.15/defconfig branch, and
>> applied patch 2/2 to Tegra's for-3.15/dt branch.
>>
>> Note that your patches were sent with an email "From" address that
>> didn't match your signed-off-by tag, yet "git send-email" didn't insert
>> a "From" header in the email body. Can you please check your git user ID
>> and/or email settings. Consequently, I had to adjust the git author
>> field in git to match your s-o-b line.
> 
> My bad. I need to update my git send-email script to use --from "Bryan
> Wu <pengw@nvidia.com>" instead of --from "Bryan Wu
> <cooloney@gmail.com>"
> 
> Need I resubmit this patchset?

No need to resent; I fixed them up.

Why not just put the correct values in ~/.gitconfig?

Perhaps this is because you switch between NVIDIA and non-NVIDIA email
addresses and/or mail servers, so you can't make ~/.gitconfig static and
universally correct? If you have a recent enough git, what I do is:

$ cat ~/.gitconfig
[include]
        path = .gitconfig-user
        path = .gitconfig-email-server
...

$ cat ~/.gitconfig-user-nvidia
[user]
	name = Stephen Warren
	email = swarren at nvidia.com

$ cat ~/.gitconfig-user-wwwdotorg
[user]
	name = Stephen Warren
	email = swarren at wwwdotorg.org

~/.gitconfig-user is a symlink to one of ~/.gitconfig-user-*, and I have
a script that deletes the link and points it at a new location:

$ cat `which git-switch-user`
#!/bin/bash

cd $HOME
mainfile=.gitconfig-user
newlink=${mainfile}-$1
if [ ! -f ${newlink} ]; then
    echo ERROR: ${newlink} not found
    exit 1
fi

rm -f ${mainfile}
ln -s ${newlink} ${mainfile}

... and the same thing for email servers.

Then, I can run e.g.:

git-switch-email-server nvidia; \
git send-email --to internal at nvidia.com *.patch; \
git-switch-email-server severn-port-forwarded

  parent reply	other threads:[~2014-02-12 20:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 23:54 [PATCH 1/2] ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig Bryan Wu
2014-02-07 23:54 ` Bryan Wu
     [not found] ` <1391817298-10600-1-git-send-email-pengw-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-07 23:54   ` [PATCH 2/2] ARM: tegra: enable PCA9546 on Cardhu Bryan Wu
2014-02-07 23:54     ` Bryan Wu
2014-02-12 19:08   ` [PATCH 1/2] ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig Stephen Warren
2014-02-12 19:08     ` Stephen Warren
     [not found]     ` <52FBC6A9.7010401-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-02-12 20:09       ` Bryan Wu
2014-02-12 20:09         ` Bryan Wu
     [not found]         ` <CAK5ve-+bzLkdwmab9sZGPk7p67ktVcK3mHQ2aUgMueH061ty6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-12 20:17           ` Stephen Warren [this message]
2014-02-12 20:17             ` Stephen Warren
     [not found]             ` <52FBD6C9.2010905-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-02-12 21:55               ` Bryan Wu
2014-02-12 21:55                 ` Bryan Wu
     [not found]                 ` <CAK5ve-+2AGO0UCf4UOMLoqGmQLp7QN08OJbZxUc-oYZzjPdFcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-12 22:35                   ` Stephen Warren
2014-02-12 22:35                     ` Stephen Warren
     [not found]                     ` <52FBF739.1060605-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-02-12 23:23                       ` Bryan Wu
2014-02-12 23:23                         ` Bryan Wu
     [not found]                         ` <CAK5ve-LHktOUNUYRZccvmmYwcAhvQiPQYoxEWkVU6kUHr4aTUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-13  2:12                           ` Stephen Warren
2014-02-13  2:12                             ` Stephen Warren
     [not found]                             ` <52FC2A1A.2070305-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-02-13  2:22                               ` Bryan Wu
2014-02-13  2:22                                 ` Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FBD6C9.2010905@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.