From: Heinz Graalfs <graalfs@linux.vnet.ibm.com>
To: Rusty Russell <rusty@rustcorp.com.au>,
"Michael S. Tsirkin" <mst@redhat.com>,
Joel Stanley <joel@jms.id.au>
Cc: virtio-dev@lists.oasis-open.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 0/3] tools/virtio: build fixes for virtio_test
Date: Thu, 13 Feb 2014 12:05:33 +0100 [thread overview]
Message-ID: <52FCA6FD.8070109@linux.vnet.ibm.com> (raw)
In-Reply-To: <87r477eic0.fsf@rustcorp.com.au>
On 13/02/14 05:40, Rusty Russell wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
>
>> On Tue, Feb 11, 2014 at 04:58:17PM +1030, Joel Stanley wrote:
>>> Recent changes to drivers/virtio broke compilation for the tests in
>>> tools/virtio. The following patches are build fixes for those changes, as well
>>> as a fix for a typo that would have never built.
>>>
>>> The changes were tested on my amd64 system against 3.14-rc2.
>>
>> Ah, thanks a lot for posting this.
>> I had this fixed in my tree but forgot to send.
>> For the series:
>>
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>>
>> Rusty, will you pick this up?
>
> Hmm, add added:
>
> Fixes: 53c18c9906441 (virtio_test: verify if virtqueue_kick() succeeded)
> Cc: Heinz Graalfs <graalfs@linux.vnet.ibm.com>
>
> Heinz, you didn't compile test your patch.
>
> Insert angry-Torvalds-face here,
> Rusty.
>
Rusty, yes, I missed to compile the test module.
I'm sorry.
Heinz
prev parent reply other threads:[~2014-02-13 11:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 6:28 [PATCH 0/3] tools/virtio: build fixes for virtio_test Joel Stanley
2014-02-11 6:28 ` [PATCH 1/3] tools/virtio: update internal copies of headers Joel Stanley
2014-02-11 6:28 ` [PATCH 2/3] tools/virtio: fix missing kmemleak_ignore symbol Joel Stanley
2014-02-11 6:28 ` [PATCH 3/3] tools/virtio: add a missing ) Joel Stanley
2014-02-11 6:57 ` [PATCH 0/3] tools/virtio: build fixes for virtio_test Michael S. Tsirkin
2014-02-13 4:28 ` Rusty Russell
2014-02-13 4:40 ` Rusty Russell
2014-02-13 11:05 ` Heinz Graalfs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FCA6FD.8070109@linux.vnet.ibm.com \
--to=graalfs@linux.vnet.ibm.com \
--cc=joel@jms.id.au \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.