From: Mugunthan V N <mugunthanvnm@ti.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
netdev@vger.kernel.org
Cc: <kernel@pengutronix.de>, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: cpsw: catch of_get_phy_mode failing and propagate error
Date: Thu, 13 Feb 2014 19:41:36 +0530 [thread overview]
Message-ID: <52FCD298.5050005@ti.com> (raw)
In-Reply-To: <1392244402-24823-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Thursday 13 February 2014 04:03 AM, Uwe Kleine-König wrote:
> It's wrong if the device tree doesn't provide a phy-mode property for
> the cpsw slaves as it is documented to be required in
> Documentation/devicetree/bindings/net/cpsw.txt.
>
> Anyhow it's nice to catch that problem, still more as it used to work
> without this property up to commit 388367a5a9fb (drivers: net: cpsw: use
> cpsw-phy-sel driver to configure phy mode) which is in v3.13-rc1.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Good catch
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
next prev parent reply other threads:[~2014-02-13 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 22:33 [PATCH] net: cpsw: catch of_get_phy_mode failing and propagate error Uwe Kleine-König
2014-02-13 14:11 ` Mugunthan V N [this message]
2014-02-13 23:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FCD298.5050005@ti.com \
--to=mugunthanvnm@ti.com \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.