From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harald Hoyer Subject: Re: [PATCH] add fsck passno to dracut --mount args Date: Thu, 13 Feb 2014 15:50:24 +0100 Message-ID: <52FCDBB0.8080509@redhat.com> References: <20140212072229.GA15908@dhcp-16-126.nay.redhat.com> <20140213144222.GG30844@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140213144222.GG30844-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: initramfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Vivek Goyal , Dave Young Cc: kexec-TuqUDEhatI4ANWPb/1PvSmm0pvjS0E/A@public.gmane.org, initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 02/13/2014 03:42 PM, Vivek Goyal wrote: > On Wed, Feb 12, 2014 at 03:22:30PM +0800, Dave Young wrote: >> We are using dracut --mount to pass fstab lines for mounting filesystems >> other than rootfs. But we did not provide passno for filesystem checking. >> >> Add passno '2' for all the --mount targets. >> >> Tested in F19 guest. >> >> Signed-off-by: Dave Young >> --- >> mkdumprd | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- kexec-tools.orig/mkdumprd >> +++ kexec-tools/mkdumprd >> @@ -104,7 +104,7 @@ to_mount() { >> _o=$(findmnt -k -f -n -r -o OPTIONS $_dev) >> _o=${_o/#ro/rw} #mount fs target as rw in 2nd kernel >> _o="${_o},nofail" #with nofail set, systemd won't block for mount failure >> - _mntopts="$_t $_o" >> + _mntopts="$_t $_o 0 2" > > What is 0 here. I think you are trying to emulate the format of an fstab > file and passing 5th and 6th field. > > I don't think they are filesystem options. If you trying to mount a file > system with 0 and 2 passed as additional parameters, mount will complain > that what is 0 and 2 it does not understand. yes, kind of... as it is now, it would generate an invalid fstab line while pop fstab_lines line; do printf "%s\n" "$line 0 0" >> "${initdir}/etc/fstab" done but most of the tools would accept that and the fsck would be done > > I am CCing harald. He might have thoughts on what's the better way to > pass the fsck_passno of filesystem being mounted. I would not mind of > passno 2 is hardcoded for anything passed in using --mount option in > dracut. we can also check if those are present, and set "0 0" as the default if nothing is given in "--mount" > > Thanks > Vivek >