From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH 5/5] iommu/arm-smmu: fix compilation issue when !CONFIG_ARM_AMBA Date: Thu, 13 Feb 2014 11:11:55 -0600 Message-ID: <52FCFCDB.5090907@codeaurora.org> References: <1391710173-4343-1-git-send-email-will.deacon@arm.com> <1391710173-4343-6-git-send-email-will.deacon@arm.com> <20140213170408.GM13576@mudshark.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140213170408.GM13576-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Will Deacon Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: iommu@lists.linux-foundation.org On 02/13/2014 11:04 AM, Will Deacon wrote: > It's harmless to enable CONFIG_ARM_AMBA, even if you don't have any AMBA > devices in your SoC, Ah, ok. It's seems obvious now, but somehow that didn't click. > it just makes your binary a bit bigger because you're > compiling in code that you don't need. Instead, you might elect to set > CONFIG_ARM_AMBA=n, at which point the arm-smmu driver will fail to build > without this patch. Ok, thanks. We discovered the same problem internally, and had the same solution, but during code reviews some concerns were raised. From mboxrd@z Thu Jan 1 00:00:00 1970 From: timur@codeaurora.org (Timur Tabi) Date: Thu, 13 Feb 2014 11:11:55 -0600 Subject: [PATCH 5/5] iommu/arm-smmu: fix compilation issue when !CONFIG_ARM_AMBA In-Reply-To: <20140213170408.GM13576@mudshark.cambridge.arm.com> References: <1391710173-4343-1-git-send-email-will.deacon@arm.com> <1391710173-4343-6-git-send-email-will.deacon@arm.com> <20140213170408.GM13576@mudshark.cambridge.arm.com> Message-ID: <52FCFCDB.5090907@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/13/2014 11:04 AM, Will Deacon wrote: > It's harmless to enable CONFIG_ARM_AMBA, even if you don't have any AMBA > devices in your SoC, Ah, ok. It's seems obvious now, but somehow that didn't click. > it just makes your binary a bit bigger because you're > compiling in code that you don't need. Instead, you might elect to set > CONFIG_ARM_AMBA=n, at which point the arm-smmu driver will fail to build > without this patch. Ok, thanks. We discovered the same problem internally, and had the same solution, but during code reviews some concerns were raised.