From: Eric Blake <eblake@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.crosthwaite@xilinx.com, akong@redhat.com,
stefanha@redhat.com, mjt@tls.msk.ru, armbru@redhat.com,
mreitz@redhat.com, aliguori@amazon.com, pbonzini@redhat.com,
lcapitulino@redhat.com, lersek@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3] vl: convert -m to QemuOpts
Date: Thu, 13 Feb 2014 10:45:43 -0700 [thread overview]
Message-ID: <52FD04C7.5030701@redhat.com> (raw)
In-Reply-To: <1392307986-27730-1-git-send-email-imammedo@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
On 02/13/2014 09:13 AM, Igor Mammedov wrote:
> Adds option to -m
> "mem" - startup memory amount
>
> For compatibility with legacy CLI if suffix-less number is passed,
> it assumes amount in MiB.
>
> Otherwise user is free to use suffixed number using suffixes b,k/K,M,G
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> v3:
> - fixes suggested by Eric Blake <eblake@redhat.com>
> - check for empty string in more efficient way
> - fix MB/MiB inconsistency
> - use EXIT_FAILURE instead of 1
> - add missing exit() if overflow occurres
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-02-13 17:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 13:50 [Qemu-devel] [PATCH v2 0/2] convert -m to QemuOpts Igor Mammedov
2014-02-13 13:50 ` [Qemu-devel] [PATCH v2 1/2] QemuOpts: introduce qemu_find_opts_singleton Igor Mammedov
2014-02-13 13:50 ` [Qemu-devel] [PATCH v2 2/2] vl: convert -m to QemuOpts Igor Mammedov
2014-02-13 15:14 ` Eric Blake
2014-02-13 16:13 ` [Qemu-devel] [PATCH v3] " Igor Mammedov
2014-02-13 17:45 ` Eric Blake [this message]
2014-02-13 20:06 ` Laszlo Ersek
2014-02-17 16:18 ` Paolo Bonzini
2014-02-17 16:42 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FD04C7.5030701@redhat.com \
--to=eblake@redhat.com \
--cc=akong@redhat.com \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.