All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: meta-freescale@yoctoproject.org
Subject: Re: [meta-fsl-arm][PATCH] image_types_fsl: explicitly state the origin of boot scripts
Date: Thu, 13 Feb 2014 11:39:53 -0700	[thread overview]
Message-ID: <52FD1179.6000403@boundarydevices.com> (raw)
In-Reply-To: <1392316629-2461-1-git-send-email-eric.nelson@boundarydevices.com>

Hi all,

On 02/13/2014 11:37 AM, Eric Nelson wrote:
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
>   classes/image_types_fsl.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/classes/image_types_fsl.bbclass b/classes/image_types_fsl.bbclass
> index 443abf7..3510452 100644
> --- a/classes/image_types_fsl.bbclass
> +++ b/classes/image_types_fsl.bbclass
> @@ -145,7 +145,7 @@ generate_imx_sdcard () {
>   		src=`echo $item | awk -F':' '{ print $1 }'`
>   		dst=`echo $item | awk -F':' '{ print $2 }'`
>
> -		mcopy -i ${WORKDIR}/boot.img -s $src ::/$dst
> +		mcopy -i ${WORKDIR}/boot.img -s ${DEPLOY_DIR_IMAGE}/$src ::/$dst
>   	done
>

I wasn't able to find how this changed, but it seems better to have
an explicit reference to the source of this operation.

Regards,


Eric



      reply	other threads:[~2014-02-13 18:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 18:37 [meta-fsl-arm][PATCH] image_types_fsl: explicitly state the origin of boot scripts Eric Nelson
2014-02-13 18:39 ` Eric Nelson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FD1179.6000403@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=meta-freescale@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.